test both clients types

Author: bruegth

src/Docker.DotNet/DockerClient.cs

@@ -44,6 +44,11 @@ internal DockerClient(DockerClientConfiguration configuration, Version requested
                     throw new Exception("TLS not supported over npipe");
                 }
 
+                if (Configuration.NativeHttpHandler)
+                {
+                    throw new Exception("Npipe not supported with native handler");
+                }
+
                 var segments = uri.Segments;
                 if (segments.Length != 3 || !segments[1].Equals("pipe/", StringComparison.OrdinalIgnoreCase))
                 {
@@ -77,23 +82,36 @@ await stream.ConnectAsync(timeout, cancellationToken)
             case "http":
                 var builder = new UriBuilder(uri)
                 {
-                    Scheme = configuration.Credentials.IsTlsCredentials() ? "https" : "http"
+                    Scheme = Configuration.Credentials.IsTlsCredentials() ? "https" : "http"
                 };
                 uri = builder.Uri;
-                if (configuration.NativeHttpHandler)
+                if (Configuration.NativeHttpHandler)
+                {
                     handler = new HttpClientHandler();
+                }
                 else
+                {
                     handler = new ManagedHandler(logger);
+                }
                 break;
 
             case "https":
-                if (configuration.NativeHttpHandler)
+                if (Configuration.NativeHttpHandler)
+                {
                     handler = new HttpClientHandler();
+                }
                 else
+                {
                     handler = new ManagedHandler(logger);
+                }
                 break;
 
             case "unix":
+                if (Configuration.NativeHttpHandler)
+                {
+                    throw new Exception("Unix sockets not supported with native handler");
+                }
+
                 var pipeString = uri.LocalPath;
                 handler = new ManagedHandler(async (host, port, cancellationToken) =>
                 {
@@ -108,7 +126,7 @@ await sock.ConnectAsync(new Microsoft.Net.Http.Client.UnixDomainSocketEndPoint(p
                 break;
 
             default:
-                throw new Exception($"Unknown URL scheme {configuration.EndpointBaseUri.Scheme}");
+                throw new Exception($"Unknown URL scheme {Configuration.EndpointBaseUri.Scheme}");
         }
 
         _endpointBaseUri = uri;

test/Docker.DotNet.Tests/IConfigOperationsTests.cs

@@ -12,10 +12,16 @@ public IConfigOperationsTests(TestFixture testFixture, ITestOutputHelper testOut
         _testOutputHelper = testOutputHelper;
     }
 
-    [Fact]
-    public async Task SwarmConfig_CanCreateAndRead()
+    public static IEnumerable<object[]> GetDockerClientTypes() =>
+        Enum.GetValues(typeof(DockerClientType))
+            .Cast<DockerClientType>()
+            .Select(t => new object[] { t });
+
+    [Theory]
+    [MemberData(nameof(GetDockerClientTypes))]
+    public async Task SwarmConfig_CanCreateAndRead(DockerClientType clientType)
     {
-        var currentConfigs = await _testFixture.DockerClient.Configs.ListConfigsAsync();
+        var currentConfigs = await _testFixture.DockerClients[clientType].Configs.ListConfigsAsync();
 
         _testOutputHelper.WriteLine($"Current Configs: {currentConfigs.Count}");
 
@@ -31,15 +37,15 @@ public async Task SwarmConfig_CanCreateAndRead()
             Config = testConfigSpec
         };
 
-        var createdConfig = await _testFixture.DockerClient.Configs.CreateConfigAsync(configParameters);
+        var createdConfig = await _testFixture.DockerClients[clientType].Configs.CreateConfigAsync(configParameters);
         Assert.NotNull(createdConfig.ID);
         _testOutputHelper.WriteLine($"Config created: {createdConfig.ID}");
 
-        var configs = await _testFixture.DockerClient.Configs.ListConfigsAsync();
+        var configs = await _testFixture.DockerClients[clientType].Configs.ListConfigsAsync();
         Assert.Contains(configs, c => c.ID == createdConfig.ID);
         _testOutputHelper.WriteLine($"Current Configs: {configs.Count}");
 
-        var configResponse = await _testFixture.DockerClient.Configs.InspectConfigAsync(createdConfig.ID);
+        var configResponse = await _testFixture.DockerClients[clientType].Configs.InspectConfigAsync(createdConfig.ID);
 
         Assert.NotNull(configResponse);
 
@@ -51,8 +57,8 @@ public async Task SwarmConfig_CanCreateAndRead()
 
         _testOutputHelper.WriteLine("Config created is the same.");
 
-        await _testFixture.DockerClient.Configs.RemoveConfigAsync(createdConfig.ID);
+        await _testFixture.DockerClients[clientType].Configs.RemoveConfigAsync(createdConfig.ID);
 
-        await Assert.ThrowsAsync<DockerApiException>(() => _testFixture.DockerClient.Configs.InspectConfigAsync(createdConfig.ID));
+        await Assert.ThrowsAsync<DockerApiException>(() => _testFixture.DockerClients[clientType].Configs.InspectConfigAsync(createdConfig.ID));
     }
 }