chore: Remove redundant null check covered by QueryString (#41)

Author: HofmeisterAn

src/Docker.DotNet/Endpoints/ContainerOperations.cs

@@ -264,7 +264,7 @@ public Task RenameContainerAsync(string id, ContainerRenameParameters parameters
             throw new ArgumentNullException(nameof(id));
         }
 
-        var queryParameters = new QueryString<ContainerRenameParameters>(parameters ?? throw new ArgumentNullException(nameof(parameters)));
+        var queryParameters = new QueryString<ContainerRenameParameters>(parameters);
         return _client.MakeRequestAsync(new[] { NoSuchContainerHandler }, HttpMethod.Post, $"containers/{id}/rename", queryParameters, cancellationToken);
     }
 

src/Docker.DotNet/Endpoints/SwarmOperations.cs

@@ -176,7 +176,7 @@ async Task<ServiceUpdateResponse> ISwarmOperations.UpdateServiceAsync(string id,
 
     async Task ISwarmOperations.UpdateSwarmAsync(SwarmUpdateParameters parameters, CancellationToken cancellationToken)
     {
-        var query = new QueryString<SwarmUpdateParameters>(parameters ?? throw new ArgumentNullException(nameof(parameters)));
+        var query = new QueryString<SwarmUpdateParameters>(parameters);
         var body = new JsonRequestContent<Spec>(parameters.Spec, DockerClient.JsonSerializer);
         await _client.MakeRequestAsync(
             new ApiResponseErrorHandlingDelegate[]

src/Docker.DotNet/JsonRequestContent.cs

@@ -1,7 +1,6 @@
 namespace Docker.DotNet;
 
-internal class JsonRequestContent<T> : IRequestContent
-    where T : class
+internal class JsonRequestContent<T> : IRequestContent where T : class
 {
     private readonly T _value;
     private readonly JsonSerializer _serializer;

src/Docker.DotNet/QueryString.cs

@@ -1,6 +1,6 @@
 namespace Docker.DotNet;
 
-internal class QueryString<T> : IQueryString
+internal class QueryString<T> : IQueryString where T : class
 {
     private T Object { get; }
 

test/Docker.DotNet.Tests/Docker.DotNet.Tests.csproj

@@ -22,6 +22,7 @@
     <Using Include="System.Collections.Generic" />
     <Using Include="System.Diagnostics" />
     <Using Include="System.Linq" />
+    <Using Include="System.Net.Http" />
     <Using Include="System.Reflection" />
     <Using Include="System.Text" />
     <Using Include="System.Threading" />

test/Docker.DotNet.Tests/JsonRequestContentTests.cs

@@ -1,5 +1,3 @@
-using System.Net.Http;
-
 namespace Docker.DotNet.Tests;
 
 public sealed class JsonRequestContentTests
@@ -13,15 +11,15 @@ public void Constructor_ThrowsArgumentNullException_WhenValueIsNull()
     [Fact]
     public void Constructor_ThrowsArgumentNullException_WhenSerializerIsNull()
     {
-        Assert.Throws<ArgumentNullException>(() => new JsonRequestContent<object>(new(), null));
+        Assert.Throws<ArgumentNullException>(() => new JsonRequestContent<object>(new object(), null));
     }
 
     [Fact]
     public async Task GetContent_Succeeds_WhenValueAndSerializerAreValid()
     {
-        JsonRequestContent<int[]> content = new([1], JsonSerializer.Instance);
-        using HttpContent httpContent = content.GetContent();
-        string jsonString = await httpContent.ReadAsStringAsync();
+        var content = new JsonRequestContent<int[]>(new[] { 1 }, JsonSerializer.Instance);
+        using var httpContent = content.GetContent();
+        var jsonString = await httpContent.ReadAsStringAsync();
         Assert.Equal("[1]", jsonString);
     }
-}
+}