Skip to content

Commit ec08ba5

Browse files
authored
fix: Don't set the Connection header to 'close' if it is already set (#26)
Signed-off-by: Andreas Häber <[email protected]>
1 parent 6317bf0 commit ec08ba5

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/Docker.DotNet/DockerClient.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -386,8 +386,8 @@ internal async Task<WriteClosableStream> MakeRequestForHijackedStreamAsync(
386386
headers = new Dictionary<string, string>();
387387
}
388388

389-
headers.Add("Connection", "tcp");
390-
headers.Add("Upgrade", "Upgrade");
389+
headers.Add("Upgrade", "tcp");
390+
headers.Add("Connection", "Upgrade");
391391

392392
var response = await PrivateMakeRequestAsync(timeout, HttpCompletionOption.ResponseHeadersRead, method, path, queryString, headers, body, cancellationToken)
393393
.ConfigureAwait(false);

src/Docker.DotNet/Microsoft.Net.Http.Client/ManagedHandler.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ private async Task<HttpResponseMessage> ProcessRequestAsync(HttpRequestMessage r
141141

142142
ProcessUrl(request);
143143
ProcessHostHeader(request);
144-
request.Headers.ConnectionClose = true; // TODO: Connection re-use is not supported.
144+
request.Headers.ConnectionClose = !request.Headers.Contains("Connection"); // TODO: Connection reuse is not supported.
145145

146146
ProxyMode proxyMode = DetermineProxyModeAndAddressLine(request);
147147
Socket socket;

0 commit comments

Comments
 (0)