Skip to content

Commit 148425f

Browse files
fix: we expect a throw when port not mapped
1 parent df8ff45 commit 148425f

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

tests/Testcontainers.Tests/Unit/Configurations/UntilHostTcpPortIsAvailableTest.cs

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,9 @@ public ValueTask DisposeAsync()
3737
[Fact]
3838
public async Task SucceededWhenPortIsAvailable()
3939
{
40-
var hostPortWaitStrategy = new UntilHostTcpPortIsAvailable(listeningPort);
40+
var untilHostTcpPortIsAvailable = new UntilHostTcpPortIsAvailable(listeningPort);
4141

42-
var succeeded = await hostPortWaitStrategy.UntilAsync(_container);
42+
var succeeded = await untilHostTcpPortIsAvailable.UntilAsync(_container);
4343

4444
Assert.True(succeeded);
4545
}
@@ -51,21 +51,19 @@ public async Task SucceededWhenPortIsAvailable()
5151
[Fact(Skip = "The GitHub Action runner allows establishing a connection to any mapped port.")]
5252
public async Task FailsWhenPortNotListening()
5353
{
54-
var hostPortWaitStrategy = new UntilHostTcpPortIsAvailable(mappedPort);
54+
var untilHostTcpPortIsAvailable = new UntilHostTcpPortIsAvailable(mappedPort);
5555

56-
var succeeded = await hostPortWaitStrategy.UntilAsync(_container);
56+
var succeeded = await untilHostTcpPortIsAvailable.UntilAsync(_container);
5757

5858
Assert.False(succeeded);
5959
}
6060

6161
[Fact]
6262
public async Task FailsWhenPortNotMapped()
6363
{
64-
var hostPortWaitStrategy = new UntilHostTcpPortIsAvailable(unmappedPort);
64+
var untilHostTcpPortIsAvailable = new UntilHostTcpPortIsAvailable(unmappedPort);
6565

66-
var succeeded = await hostPortWaitStrategy.UntilAsync(_container);
67-
68-
Assert.False(succeeded);
66+
await Assert.ThrowsAsync<System.InvalidOperationException>(() => untilHostTcpPortIsAvailable.UntilAsync(_container));
6967
}
7068
}
7169
}

0 commit comments

Comments
 (0)