Skip to content

Commit 8ac4b0d

Browse files
authored
chore: Algin module configurations (#1357)
1 parent 40227bf commit 8ac4b0d

File tree

9 files changed

+42
-41
lines changed

9 files changed

+42
-41
lines changed

.node-version

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
lts/*

src/Testcontainers.DynamoDb/DynamoDbBuilder.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,11 @@ public DynamoDbBuilder()
2020
/// <summary>
2121
/// Initializes a new instance of the <see cref="DynamoDbBuilder" /> class.
2222
/// </summary>
23-
/// <param name="dockerResourceConfiguration">The Docker resource configuration.</param>
24-
private DynamoDbBuilder(DynamoDbConfiguration dockerResourceConfiguration)
25-
: base(dockerResourceConfiguration)
23+
/// <param name="resourceConfiguration">The Docker resource configuration.</param>
24+
private DynamoDbBuilder(DynamoDbConfiguration resourceConfiguration)
25+
: base(resourceConfiguration)
2626
{
27-
DockerResourceConfiguration = dockerResourceConfiguration;
27+
DockerResourceConfiguration = resourceConfiguration;
2828
}
2929

3030
/// <inheritdoc />
@@ -48,13 +48,13 @@ protected override DynamoDbBuilder Init()
4848
}
4949

5050
/// <inheritdoc />
51-
protected override DynamoDbBuilder Clone(IContainerConfiguration resourceConfiguration)
51+
protected override DynamoDbBuilder Clone(IResourceConfiguration<CreateContainerParameters> resourceConfiguration)
5252
{
5353
return Merge(DockerResourceConfiguration, new DynamoDbConfiguration(resourceConfiguration));
5454
}
5555

5656
/// <inheritdoc />
57-
protected override DynamoDbBuilder Clone(IResourceConfiguration<CreateContainerParameters> resourceConfiguration)
57+
protected override DynamoDbBuilder Clone(IContainerConfiguration resourceConfiguration)
5858
{
5959
return Merge(DockerResourceConfiguration, new DynamoDbConfiguration(resourceConfiguration));
6060
}

src/Testcontainers.EventStoreDb/EventStoreDbBuilder.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,11 @@ public EventStoreDbBuilder()
2020
/// <summary>
2121
/// Initializes a new instance of the <see cref="EventStoreDbBuilder" /> class.
2222
/// </summary>
23-
/// <param name="dockerResourceConfiguration">The Docker resource configuration.</param>
24-
private EventStoreDbBuilder(EventStoreDbConfiguration dockerResourceConfiguration)
25-
: base(dockerResourceConfiguration)
23+
/// <param name="resourceConfiguration">The Docker resource configuration.</param>
24+
private EventStoreDbBuilder(EventStoreDbConfiguration resourceConfiguration)
25+
: base(resourceConfiguration)
2626
{
27-
DockerResourceConfiguration = dockerResourceConfiguration;
27+
DockerResourceConfiguration = resourceConfiguration;
2828
}
2929

3030
/// <inheritdoc />
@@ -50,13 +50,13 @@ protected override EventStoreDbBuilder Init()
5050
}
5151

5252
/// <inheritdoc />
53-
protected override EventStoreDbBuilder Clone(IContainerConfiguration resourceConfiguration)
53+
protected override EventStoreDbBuilder Clone(IResourceConfiguration<CreateContainerParameters> resourceConfiguration)
5454
{
5555
return Merge(DockerResourceConfiguration, new EventStoreDbConfiguration(resourceConfiguration));
5656
}
5757

5858
/// <inheritdoc />
59-
protected override EventStoreDbBuilder Clone(IResourceConfiguration<CreateContainerParameters> resourceConfiguration)
59+
protected override EventStoreDbBuilder Clone(IContainerConfiguration resourceConfiguration)
6060
{
6161
return Merge(DockerResourceConfiguration, new EventStoreDbConfiguration(resourceConfiguration));
6262
}

src/Testcontainers.FakeGcsServer/FakeGcsServerBuilder.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,11 @@ public FakeGcsServerBuilder()
2222
/// <summary>
2323
/// Initializes a new instance of the <see cref="FakeGcsServerBuilder" /> class.
2424
/// </summary>
25-
/// <param name="dockerResourceConfiguration">The Docker resource configuration.</param>
26-
private FakeGcsServerBuilder(FakeGcsServerConfiguration dockerResourceConfiguration)
27-
: base(dockerResourceConfiguration)
25+
/// <param name="resourceConfiguration">The Docker resource configuration.</param>
26+
private FakeGcsServerBuilder(FakeGcsServerConfiguration resourceConfiguration)
27+
: base(resourceConfiguration)
2828
{
29-
DockerResourceConfiguration = dockerResourceConfiguration;
29+
DockerResourceConfiguration = resourceConfiguration;
3030
}
3131

3232
/// <inheritdoc />

src/Testcontainers.LocalStack/LocalStackBuilder.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,11 @@ public LocalStackBuilder()
2020
/// <summary>
2121
/// Initializes a new instance of the <see cref="LocalStackBuilder" /> class.
2222
/// </summary>
23-
/// <param name="dockerResourceConfiguration">The Docker resource configuration.</param>
24-
private LocalStackBuilder(LocalStackConfiguration dockerResourceConfiguration)
25-
: base(dockerResourceConfiguration)
23+
/// <param name="resourceConfiguration">The Docker resource configuration.</param>
24+
private LocalStackBuilder(LocalStackConfiguration resourceConfiguration)
25+
: base(resourceConfiguration)
2626
{
27-
DockerResourceConfiguration = dockerResourceConfiguration;
27+
DockerResourceConfiguration = resourceConfiguration;
2828
}
2929

3030
/// <inheritdoc />
@@ -48,13 +48,13 @@ protected override LocalStackBuilder Init()
4848
}
4949

5050
/// <inheritdoc />
51-
protected override LocalStackBuilder Clone(IContainerConfiguration resourceConfiguration)
51+
protected override LocalStackBuilder Clone(IResourceConfiguration<CreateContainerParameters> resourceConfiguration)
5252
{
5353
return Merge(DockerResourceConfiguration, new LocalStackConfiguration(resourceConfiguration));
5454
}
5555

5656
/// <inheritdoc />
57-
protected override LocalStackBuilder Clone(IResourceConfiguration<CreateContainerParameters> resourceConfiguration)
57+
protected override LocalStackBuilder Clone(IContainerConfiguration resourceConfiguration)
5858
{
5959
return Merge(DockerResourceConfiguration, new LocalStackConfiguration(resourceConfiguration));
6060
}

src/Testcontainers.Minio/MinioBuilder.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,11 @@ public MinioBuilder()
2424
/// <summary>
2525
/// Initializes a new instance of the <see cref="MinioBuilder" /> class.
2626
/// </summary>
27-
/// <param name="dockerResourceConfiguration">The Docker resource configuration.</param>
28-
private MinioBuilder(MinioConfiguration dockerResourceConfiguration)
29-
: base(dockerResourceConfiguration)
27+
/// <param name="resourceConfiguration">The Docker resource configuration.</param>
28+
private MinioBuilder(MinioConfiguration resourceConfiguration)
29+
: base(resourceConfiguration)
3030
{
31-
DockerResourceConfiguration = dockerResourceConfiguration;
31+
DockerResourceConfiguration = resourceConfiguration;
3232
}
3333

3434
/// <inheritdoc />
@@ -91,13 +91,13 @@ protected override void Validate()
9191
}
9292

9393
/// <inheritdoc />
94-
protected override MinioBuilder Clone(IContainerConfiguration resourceConfiguration)
94+
protected override MinioBuilder Clone(IResourceConfiguration<CreateContainerParameters> resourceConfiguration)
9595
{
9696
return Merge(DockerResourceConfiguration, new MinioConfiguration(resourceConfiguration));
9797
}
9898

9999
/// <inheritdoc />
100-
protected override MinioBuilder Clone(IResourceConfiguration<CreateContainerParameters> resourceConfiguration)
100+
protected override MinioBuilder Clone(IContainerConfiguration resourceConfiguration)
101101
{
102102
return Merge(DockerResourceConfiguration, new MinioConfiguration(resourceConfiguration));
103103
}

tests/Testcontainers.Keycloak.Tests/KeycloakContainerTest.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,11 @@ public async Task GetOpenIdEndpointReturnsHttpStatusCodeOk()
2727
httpClient.BaseAddress = new Uri(_keycloakContainer.GetBaseAddress());
2828

2929
// When
30-
using var response = await httpClient.GetAsync("/realms/master/.well-known/openid-configuration")
30+
using var httpResponse = await httpClient.GetAsync("/realms/master/.well-known/openid-configuration")
3131
.ConfigureAwait(true);
3232

3333
// Then
34-
Assert.Equal(HttpStatusCode.OK, response.StatusCode);
34+
Assert.Equal(HttpStatusCode.OK, httpResponse.StatusCode);
3535
}
3636

3737
[Fact]

tests/Testcontainers.Nats.Tests/NatsContainerTest.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,18 +24,18 @@ public Task DisposeAsync()
2424
public async Task HealthcheckReturnsHttpStatusCodeOk()
2525
{
2626
// Given
27-
using var client = new HttpClient();
28-
client.BaseAddress = new Uri(_natsContainer.GetManagementEndpoint());
27+
using var httpClient = new HttpClient();
28+
httpClient.BaseAddress = new Uri(_natsContainer.GetManagementEndpoint());
2929

3030
// When
31-
using var response = await client.GetAsync("/healthz")
31+
using var httpResponse = await httpClient.GetAsync("/healthz")
3232
.ConfigureAwait(true);
3333

34-
var jsonStatusString = await response.Content.ReadAsStringAsync()
34+
var jsonStatusString = await httpResponse.Content.ReadAsStringAsync()
3535
.ConfigureAwait(true);
3636

3737
// Then
38-
Assert.Equal(HttpStatusCode.OK, response.StatusCode);
38+
Assert.Equal(HttpStatusCode.OK, httpResponse.StatusCode);
3939
Assert.Equal("{\"status\":\"ok\"}", jsonStatusString);
4040
}
4141

tests/Testcontainers.Pulsar.Tests/PulsarContainerTest.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -84,20 +84,20 @@ public PulsarAuthConfiguration()
8484
{
8585
}
8686
}
87-
87+
8888
[UsedImplicitly]
89-
public sealed class PulsarDefaultConfigurationLts4 : PulsarContainerTest
89+
public sealed class PulsarV4Configuration : PulsarContainerTest
9090
{
91-
public PulsarDefaultConfigurationLts4()
91+
public PulsarV4Configuration()
9292
: base(new PulsarBuilder().WithImage("apachepulsar/pulsar:4.0.2").Build(), false)
9393
{
9494
}
9595
}
96-
96+
9797
[UsedImplicitly]
98-
public sealed class PulsarAuthConfigurationLts4 : PulsarContainerTest
98+
public sealed class PulsarV4AuthConfiguration : PulsarContainerTest
9999
{
100-
public PulsarAuthConfigurationLts4()
100+
public PulsarV4AuthConfiguration()
101101
: base(new PulsarBuilder().WithImage("apachepulsar/pulsar:4.0.2").WithAuthentication().Build(), true)
102102
{
103103
}

0 commit comments

Comments
 (0)