Skip to content

Commit dab0069

Browse files
committed
Update signing logic in Directory.Build.props
- Enable conditional assembly signing based on CI or explicit request. - Separate `InternalsVisibleTo` configurations for signed and unsigned builds. - Refactor related MSBuild properties for clarity and maintainability.
1 parent 5666f22 commit dab0069

File tree

1 file changed

+12
-3
lines changed

1 file changed

+12
-3
lines changed

Directory.Build.props

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,14 @@
2121
<RepositoryUrl>https://github.com/testcontainers/testcontainers-dotnet</RepositoryUrl>
2222
</PropertyGroup>
2323
<PropertyGroup>
24-
<AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory)src/strongname.snk</AssemblyOriginatorKeyFile>
25-
<SignAssembly>true</SignAssembly>
24+
<!-- Enable signing only in CI or when explicitly requested -->
25+
<SignAssembly Condition="'$(SIGN_ASSEMBLY)' == 'true' or '$(CI)' == 'true'">true</SignAssembly>
26+
<SignAssembly Condition="'$(SignAssembly)' == ''">false</SignAssembly>
2627
<DebugType>embedded</DebugType>
2728
</PropertyGroup>
29+
<PropertyGroup Condition="'$(SignAssembly)' == 'true'">
30+
<AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory)src/strongname.snk</AssemblyOriginatorKeyFile>
31+
</PropertyGroup>
2832
<PropertyGroup>
2933
<NoWarn>CA1859,CA1861,CS0618,CS1591,xUnit1044,xUnit1045</NoWarn>
3034
</PropertyGroup>
@@ -41,9 +45,14 @@
4145
<None Include="$(MSBuildThisFileDirectory)LICENSE" Visible="false" Pack="true" PackagePath="" />
4246
<None Include="$(MSBuildThisFileDirectory)README.md" Visible="false" Pack="true" PackagePath="" />
4347
</ItemGroup>
44-
<ItemGroup>
48+
<ItemGroup Condition="'$(SignAssembly)' == 'true'">
4549
<AssemblyAttribute Include="System.Runtime.CompilerServices.InternalsVisibleTo">
4650
<_Parameter1>Testcontainers.Tests, PublicKey=$([System.IO.File]::ReadAllText($(MSBuildThisFileDirectory)src/strongname.pub))</_Parameter1>
4751
</AssemblyAttribute>
4852
</ItemGroup>
53+
<ItemGroup Condition="'$(SignAssembly)' != 'true'">
54+
<AssemblyAttribute Include="System.Runtime.CompilerServices.InternalsVisibleTo">
55+
<_Parameter1>Testcontainers.Tests</_Parameter1>
56+
</AssemblyAttribute>
57+
</ItemGroup>
4958
</Project>

0 commit comments

Comments
 (0)