chore(exec): remove uses of ExecOptions.Detach (#3211)

* chore: exec: remove uses of ExecOptions.Detach

This option is not actually used by the client, and not handled
by the API, so removing its use.

Signed-off-by: Sebastiaan van Stijn <[email protected]>

* chore: modules/ollama: remove uses of ExecOptions.Detach

This option is not actually used by the client, and not handled
by the API, and is planned to be removed in a future release
so removing its use.

Signed-off-by: Sebastiaan van Stijn <[email protected]>

---------

Signed-off-by: Sebastiaan van Stijn <[email protected]>

Author: thaJeztah

exec/processor.go

@@ -25,7 +25,6 @@ func NewProcessOptions(cmd []string) *ProcessOptions {
 	return &ProcessOptions{
 		ExecConfig: container.ExecOptions{
 			Cmd:          cmd,
-			Detach:       false,
 			AttachStdout: true,
 			AttachStderr: true,
 		},

modules/ollama/local.go

@@ -408,9 +408,6 @@ func (c *localProcess) validateExecOptions(options container.ExecOptions) error
 	if options.Tty {
 		errs = append(errs, fmt.Errorf("tty: %w", errors.ErrUnsupported))
 	}
-	if options.Detach {
-		errs = append(errs, fmt.Errorf("detach: %w", errors.ErrUnsupported))
-	}
 	if options.DetachKeys != "" {
 		errs = append(errs, fmt.Errorf("detach keys: %w", errors.ErrUnsupported))
 	}

modules/ollama/local_test.go

@@ -483,15 +483,6 @@ func TestRun_localExec(t *testing.T) {
 		require.Nil(t, r)
 	})
 
-	t.Run("unsupported-option-detach", func(t *testing.T) {
-		code, r, err := ollamaContainer.Exec(ctx, []string{testBinary, "-v"}, tcexec.ProcessOptionFunc(func(opts *tcexec.ProcessOptions) {
-			opts.ExecConfig.Detach = true
-		}))
-		require.ErrorIs(t, err, errors.ErrUnsupported)
-		require.Equal(t, 1, code)
-		require.Nil(t, r)
-	})
-
 	t.Run("unsupported-option-detach-keys", func(t *testing.T) {
 		code, r, err := ollamaContainer.Exec(ctx, []string{testBinary, "-v"}, tcexec.ProcessOptionFunc(func(opts *tcexec.ProcessOptions) {
 			opts.ExecConfig.DetachKeys = "ctrl-p,ctrl-q"