Skip to content

Commit cff37d9

Browse files
committed
fix: another lint pass
1 parent ae49941 commit cff37d9

File tree

4 files changed

+11
-13
lines changed

4 files changed

+11
-13
lines changed

modules/firebase/firebase_test.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ import (
1010
"github.com/stretchr/testify/require"
1111

1212
"github.com/testcontainers/testcontainers-go"
13-
1413
"github.com/testcontainers/testcontainers-go/modules/firebase"
1514
)
1615

@@ -24,7 +23,6 @@ func TestFirebase(t *testing.T) {
2423
testcontainers.CleanupContainer(t, ctr)
2524
require.NoError(t, err)
2625

27-
// perform requireions
2826
// Ports are linked to the example config in firebase/firebase.json
2927

3028
firestoreURL, err := ctr.ConnectionString(ctx, "8080/tcp")
@@ -59,7 +57,7 @@ func TestFirebaseBadDirectory(t *testing.T) {
5957
)
6058
// In this case, the file gets copied over at /srv/failure (instead of /srv/firebase)
6159
// and this stops working.
62-
// What would be a solution here? Previously I just added an requireion that the root must
60+
// What would be a solution here? Previously I just added a check that the root must
6361
// end in "/firebase"... I could do the same.
6462
testcontainers.CleanupContainer(t, ctr)
6563
require.Error(t, err)

modules/firebase/go.mod

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,8 @@ require (
5151
github.com/pkg/errors v0.9.1 // indirect
5252
github.com/pmezard/go-difflib v1.0.0 // indirect
5353
github.com/power-devops/perfstat v0.0.0-20210106213030-5aafc221ea8c // indirect
54-
github.com/shirou/gopsutil/v4 v4.25.1 // indirect
54+
github.com/rogpeppe/go-internal v1.14.1 // indirect
55+
github.com/shirou/gopsutil/v4 v4.25.2 // indirect
5556
github.com/sirupsen/logrus v1.9.3 // indirect
5657
github.com/tklauser/go-sysconf v0.3.12 // indirect
5758
github.com/tklauser/numcpus v0.6.1 // indirect
@@ -76,7 +77,7 @@ require (
7677
google.golang.org/genproto/googleapis/api v0.0.0-20241118233622-e639e219e697 // indirect
7778
google.golang.org/genproto/googleapis/rpc v0.0.0-20241209162323-e6fa225c2576 // indirect
7879
google.golang.org/grpc v1.67.3 // indirect
79-
google.golang.org/protobuf v1.35.2 // indirect
80+
google.golang.org/protobuf v1.36.5 // indirect
8081
gopkg.in/yaml.v3 v3.0.1 // indirect
8182
)
8283

modules/firebase/go.sum

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -103,10 +103,10 @@ github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZb
103103
github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
104104
github.com/power-devops/perfstat v0.0.0-20210106213030-5aafc221ea8c h1:ncq/mPwQF4JjgDlrVEn3C11VoGHZN7m8qihwgMEtzYw=
105105
github.com/power-devops/perfstat v0.0.0-20210106213030-5aafc221ea8c/go.mod h1:OmDBASR4679mdNQnz2pUhc2G8CO2JrUAVFDRBDP/hJE=
106-
github.com/rogpeppe/go-internal v1.13.1 h1:KvO1DLK/DRN07sQ1LQKScxyZJuNnedQ5/wKSR38lUII=
107-
github.com/rogpeppe/go-internal v1.13.1/go.mod h1:uMEvuHeurkdAXX61udpOXGD/AzZDWNMNyH2VO9fmH0o=
108-
github.com/shirou/gopsutil/v4 v4.25.1 h1:QSWkTc+fu9LTAWfkZwZ6j8MSUk4A2LV7rbH0ZqmLjXs=
109-
github.com/shirou/gopsutil/v4 v4.25.1/go.mod h1:RoUCUpndaJFtT+2zsZzzmhvbfGoDCJ7nFXKJf8GqJbI=
106+
github.com/rogpeppe/go-internal v1.14.1 h1:UQB4HGPB6osV0SQTLymcB4TgvyWu6ZyliaW0tI/otEQ=
107+
github.com/rogpeppe/go-internal v1.14.1/go.mod h1:MaRKkUm5W0goXpeCfT7UZI6fk/L7L7so1lCWt35ZSgc=
108+
github.com/shirou/gopsutil/v4 v4.25.2 h1:NMscG3l2CqtWFS86kj3vP7soOczqrQYIEhO/pMvvQkk=
109+
github.com/shirou/gopsutil/v4 v4.25.2/go.mod h1:34gBYJzyqCDT11b6bMHP0XCvWeU3J61XRT7a2EmCRTA=
110110
github.com/sirupsen/logrus v1.9.3 h1:dueUQJ1C2q9oE3F7wvmSGAaVtTmUizReu6fjN8uqzbQ=
111111
github.com/sirupsen/logrus v1.9.3/go.mod h1:naHLuLoDiP4jHNo9R0sCBMtWGeIprob74mVsIT4qYEQ=
112112
github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
@@ -202,8 +202,8 @@ google.golang.org/genproto/googleapis/rpc v0.0.0-20241209162323-e6fa225c2576 h1:
202202
google.golang.org/genproto/googleapis/rpc v0.0.0-20241209162323-e6fa225c2576/go.mod h1:5uTbfoYQed2U9p3KIj2/Zzm02PYhndfdmML0qC3q3FU=
203203
google.golang.org/grpc v1.67.3 h1:OgPcDAFKHnH8X3O4WcO4XUc8GRDeKsKReqbQtiCj7N8=
204204
google.golang.org/grpc v1.67.3/go.mod h1:YGaHCc6Oap+FzBJTZLBzkGSYt/cvGPFTPxkn7QfSU8s=
205-
google.golang.org/protobuf v1.35.2 h1:8Ar7bF+apOIoThw1EdZl0p1oWvMqTHmpA2fRTyZO8io=
206-
google.golang.org/protobuf v1.35.2/go.mod h1:9fA7Ob0pmnwhb644+1+CVWFRbNajQ6iRojtC/QF5bRE=
205+
google.golang.org/protobuf v1.36.5 h1:tPhr+woSbjfYvY6/GPufUoYizxw1cF/yFoxJ2fmpwlM=
206+
google.golang.org/protobuf v1.36.5/go.mod h1:9fA7Ob0pmnwhb644+1+CVWFRbNajQ6iRojtC/QF5bRE=
207207
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
208208
gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c h1:Hei/4ADfdWqJk1ZMxUNpqntNwaWcugrBjAiHlqqRiVk=
209209
gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c/go.mod h1:JHkPIbrfpd72SG/EVd6muEfDQjcINNoR0C8j2r3qZ4Q=

modules/firebase/options.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@ import (
44
"github.com/testcontainers/testcontainers-go"
55
)
66

7-
type options struct {
8-
}
7+
type options struct{}
98

109
// Compiler check to ensure that Option implements the testcontainers.ContainerCustomizer interface.
1110
var _ testcontainers.ContainerCustomizer = (Option)(nil)

0 commit comments

Comments
 (0)