Skip to content

Commit 0218c20

Browse files
authored
Move localstack's tests to aws sdk v2 (#10592)
1 parent a26d58f commit 0218c20

File tree

5 files changed

+172
-240
lines changed

5 files changed

+172
-240
lines changed

docs/modules/localstack.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,6 @@ public LocalStackContainer localstack = new LocalStackContainer(localstackImage)
1616

1717
## Creating a client using AWS SDK
1818

19-
<!--codeinclude-->
20-
[AWS SDK V1](../../modules/localstack/src/test/java/org/testcontainers/containers/localstack/LocalstackContainerTest.java) inside_block:with_aws_sdk_v1
21-
<!--/codeinclude-->
22-
2319
<!--codeinclude-->
2420
[AWS SDK V2](../../modules/localstack/src/test/java/org/testcontainers/containers/localstack/LocalstackContainerTest.java) inside_block:with_aws_sdk_v2
2521
<!--/codeinclude-->

modules/localstack/build.gradle

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,12 @@ description = "Testcontainers :: Localstack"
33
dependencies {
44
api project(':testcontainers')
55

6-
testImplementation platform("com.amazonaws:aws-java-sdk-bom:1.12.572")
7-
testImplementation 'com.amazonaws:aws-java-sdk-s3'
8-
testImplementation 'com.amazonaws:aws-java-sdk-sqs'
9-
testImplementation 'com.amazonaws:aws-java-sdk-logs'
10-
testImplementation 'com.amazonaws:aws-java-sdk-lambda'
11-
testImplementation 'com.amazonaws:aws-java-sdk-core'
12-
testImplementation 'software.amazon.awssdk:s3:2.32.14'
6+
testImplementation platform("software.amazon.awssdk:bom:2.32.14")
7+
testImplementation 'software.amazon.awssdk:s3'
8+
testImplementation 'software.amazon.awssdk:sqs'
9+
testImplementation 'software.amazon.awssdk:cloudwatchlogs'
10+
testImplementation 'software.amazon.awssdk:lambda'
11+
testImplementation 'software.amazon.awssdk:kms'
1312
testImplementation 'org.assertj:assertj-core:3.27.3'
1413
}
1514

modules/localstack/src/test/java/org/testcontainers/containers/localstack/LegacyModeTest.java

Lines changed: 7 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package org.testcontainers.containers.localstack;
22

3-
import com.amazonaws.client.builder.AwsClientBuilder;
43
import com.github.dockerjava.api.DockerClient;
54
import lombok.AllArgsConstructor;
65
import org.junit.BeforeClass;
@@ -20,7 +19,9 @@
2019
@RunWith(Enclosed.class)
2120
public class LegacyModeTest {
2221

23-
private static DockerImageName LOCALSTACK_CUSTOM_TAG = LocalstackTestImages.LOCALSTACK_IMAGE.withTag("custom");
22+
private static DockerImageName LOCALSTACK_CUSTOM_TAG = DockerImageName
23+
.parse("localstack/localstack:0.12.8")
24+
.withTag("custom");
2425

2526
@RunWith(Parameterized.class)
2627
@AllArgsConstructor
@@ -54,21 +55,9 @@ public void samePortIsExposedForAllServices() {
5455
assertThat(localstack.getEndpointOverride(Service.SQS).toString())
5556
.as("Endpoint overrides are different")
5657
.isEqualTo(localstack.getEndpointOverride(Service.S3).toString());
57-
assertThat(
58-
new AwsClientBuilder.EndpointConfiguration(
59-
localstack.getEndpointOverride(Service.SQS).toString(),
60-
localstack.getRegion()
61-
)
62-
.getServiceEndpoint()
63-
)
58+
assertThat(localstack.getEndpointOverride(Service.SQS).toString())
6459
.as("Endpoint configuration have different endpoints")
65-
.isEqualTo(
66-
new AwsClientBuilder.EndpointConfiguration(
67-
localstack.getEndpointOverride(Service.S3).toString(),
68-
localstack.getRegion()
69-
)
70-
.getServiceEndpoint()
71-
);
60+
.isEqualTo(localstack.getEndpointOverride(Service.S3).toString());
7261
} finally {
7362
localstack.stop();
7463
}
@@ -119,21 +108,9 @@ public void differentPortsAreExposed() {
119108
assertThat(localstack.getEndpointOverride(Service.SQS).toString())
120109
.as("Endpoint overrides are different")
121110
.isNotEqualTo(localstack.getEndpointOverride(Service.S3).toString());
122-
assertThat(
123-
new AwsClientBuilder.EndpointConfiguration(
124-
localstack.getEndpointOverride(Service.SQS).toString(),
125-
localstack.getRegion()
126-
)
127-
.getServiceEndpoint()
128-
)
111+
assertThat(localstack.getEndpointOverride(Service.SQS).toString())
129112
.as("Endpoint configuration have different endpoints")
130-
.isNotEqualTo(
131-
new AwsClientBuilder.EndpointConfiguration(
132-
localstack.getEndpointOverride(Service.S3).toString(),
133-
localstack.getRegion()
134-
)
135-
.getServiceEndpoint()
136-
);
113+
.isNotEqualTo(localstack.getEndpointOverride(Service.S3).toString());
137114
} finally {
138115
localstack.stop();
139116
}

0 commit comments

Comments
 (0)