Skip to content

Commit 2f61104

Browse files
committed
Move MariaDB tests to JUnit Jupiter
1 parent 8e07d8c commit 2f61104

File tree

3 files changed

+17
-14
lines changed

3 files changed

+17
-14
lines changed

modules/mariadb/build.gradle

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@ dependencies {
66
compileOnly project(':testcontainers-r2dbc')
77
compileOnly 'org.mariadb:r2dbc-mariadb:1.0.3'
88

9+
testRuntimeOnly 'org.junit.platform:junit-platform-launcher:1.11.0'
10+
11+
testImplementation 'org.junit.jupiter:junit-jupiter:5.13.4'
912
testImplementation project(':testcontainers-jdbc-test')
1013
testImplementation 'org.mariadb.jdbc:mariadb-java-client:3.5.5'
1114

@@ -18,3 +21,7 @@ tasks.japicmp {
1821
"org.testcontainers.containers.MariaDBContainer"
1922
]
2023
}
24+
25+
test {
26+
useJUnitPlatform()
27+
}

modules/mariadb/src/test/java/org/testcontainers/jdbc/mariadb/MariaDBJDBCDriverTest.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,12 @@
11
package org.testcontainers.jdbc.mariadb;
22

3-
import org.junit.runner.RunWith;
4-
import org.junit.runners.Parameterized;
53
import org.testcontainers.jdbc.AbstractJDBCDriverTest;
64

75
import java.util.Arrays;
86
import java.util.EnumSet;
97

10-
@RunWith(Parameterized.class)
11-
public class MariaDBJDBCDriverTest extends AbstractJDBCDriverTest {
8+
class MariaDBJDBCDriverTest extends AbstractJDBCDriverTest {
129

13-
@Parameterized.Parameters(name = "{index} - {0}")
1410
public static Iterable<Object[]> data() {
1511
return Arrays.asList(
1612
new Object[][] {

modules/mariadb/src/test/java/org/testcontainers/junit/mariadb/SimpleMariaDBTest.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package org.testcontainers.junit.mariadb;
22

33
import org.apache.commons.lang3.SystemUtils;
4-
import org.junit.Test;
4+
import org.junit.jupiter.api.Test;
55
import org.testcontainers.MariaDBTestImages;
66
import org.testcontainers.containers.MariaDBContainer;
77
import org.testcontainers.db.AbstractContainerDatabaseTest;
@@ -21,10 +21,10 @@
2121
import static org.assertj.core.api.Assumptions.assumeThat;
2222
import static org.junit.Assume.assumeFalse;
2323

24-
public class SimpleMariaDBTest extends AbstractContainerDatabaseTest {
24+
class SimpleMariaDBTest extends AbstractContainerDatabaseTest {
2525

2626
@Test
27-
public void testSimple() throws SQLException {
27+
void testSimple() throws SQLException {
2828
try ( // container {
2929
MariaDBContainer<?> mariadb = new MariaDBContainer<>("mariadb:10.3.39")
3030
// }
@@ -39,7 +39,7 @@ public void testSimple() throws SQLException {
3939
}
4040

4141
@Test
42-
public void testSpecificVersion() throws SQLException {
42+
void testSpecificVersion() throws SQLException {
4343
try (
4444
MariaDBContainer<?> mariadbOldVersion = new MariaDBContainer<>(
4545
MariaDBTestImages.MARIADB_IMAGE.withTag("10.3.39")
@@ -57,7 +57,7 @@ public void testSpecificVersion() throws SQLException {
5757
}
5858

5959
@Test
60-
public void testMariaDBWithCustomIniFile() throws SQLException {
60+
void testMariaDBWithCustomIniFile() throws SQLException {
6161
assumeFalse(SystemUtils.IS_OS_WINDOWS);
6262

6363
try (
@@ -73,7 +73,7 @@ public void testMariaDBWithCustomIniFile() throws SQLException {
7373
}
7474

7575
@Test
76-
public void testMariaDBWithCommandOverride() throws SQLException {
76+
void testMariaDBWithCommandOverride() throws SQLException {
7777
try (
7878
MariaDBContainer<?> mariadbCustomConfig = new MariaDBContainer<>(MariaDBTestImages.MARIADB_IMAGE)
7979
.withCommand("mysqld --auto_increment_increment=10")
@@ -87,7 +87,7 @@ public void testMariaDBWithCommandOverride() throws SQLException {
8787
}
8888

8989
@Test
90-
public void testWithAdditionalUrlParamInJdbcUrl() {
90+
void testWithAdditionalUrlParamInJdbcUrl() {
9191
MariaDBContainer<?> mariaDBContainer = new MariaDBContainer<>(MariaDBTestImages.MARIADB_IMAGE)
9292
.withUrlParam("connectTimeout", "40000")
9393
.withUrlParam("rewriteBatchedStatements", "true");
@@ -105,7 +105,7 @@ public void testWithAdditionalUrlParamInJdbcUrl() {
105105
}
106106

107107
@Test
108-
public void testWithOnlyUserReadableCustomIniFile() throws Exception {
108+
void testWithOnlyUserReadableCustomIniFile() throws Exception {
109109
assumeThat(FileSystems.getDefault().supportedFileAttributeViews().contains("posix")).isTrue();
110110

111111
try (
@@ -136,7 +136,7 @@ public void testWithOnlyUserReadableCustomIniFile() throws Exception {
136136
}
137137

138138
@Test
139-
public void testEmptyPasswordWithRootUser() throws SQLException {
139+
void testEmptyPasswordWithRootUser() throws SQLException {
140140
try (MariaDBContainer<?> mysql = new MariaDBContainer<>("mariadb:11.2.4").withUsername("root")) {
141141
mysql.start();
142142

0 commit comments

Comments
 (0)