Don't extend configuration compileOnly and testCompile from shaded (#9579)

patrick-dedication · eddumelendez · web-flow · commit 2fa7f65f2df8 · 2025-02-18T09:48:53.000-06:00
Don't extend configuration testCompile from shaded

* using testCompile has been discouraged since Gradle 3.4
* made sure dependencies on all other configurations are unchanged
* no need to change it to testImplementation since testCompileClasspath
  and testRuntimeClasspath extend from implementation

Don't extend configuration compileOnly from shaded

* compileClasspath already extends from implementation

---------

Co-authored-by: Eddú Meléndez Gonzales &lt;eddu.melendez@gmail.com&gt;
diff --git a/gradle/shading.gradle b/gradle/shading.gradle
@@ -4,7 +4,7 @@ apply plugin: 'com.gradleup.shadow'
 
 configurations {
     shaded
-    [apiElements, implementation, compileOnly, testCompile]*.extendsFrom shaded
+    [apiElements, implementation]*.extendsFrom shaded
 }
 configurations.api.canBeResolved = true
 

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@ apply plugin: 'com.gradleup.shadow'`
`4`	`4`
`5`	`5`	`configurations {`
`6`	`6`	`shaded`
`7`		`- [apiElements, implementation, compileOnly, testCompile]*.extendsFrom shaded`
	`7`	`+ [apiElements, implementation]*.extendsFrom shaded`
`8`	`8`	`}`
`9`	`9`	`configurations.api.canBeResolved = true`
`10`	`10`