Skip to content

Commit 3175141

Browse files
committed
Use ComparableVersion for checking Selenium version
1 parent ef46d9a commit 3175141

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

modules/selenium/src/main/java/org/testcontainers/containers/BrowserWebDriverContainer.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import org.testcontainers.containers.wait.strategy.WaitStrategy;
2424
import org.testcontainers.lifecycle.TestDescription;
2525
import org.testcontainers.lifecycle.TestLifecycleAware;
26+
import org.testcontainers.utility.ComparableVersion;
2627
import org.testcontainers.utility.DockerImageName;
2728

2829
import java.io.File;
@@ -245,7 +246,7 @@ public static String getDockerImageForCapabilities(Capabilities capabilities, St
245246
}
246247

247248
private static DockerImageName getStandardImageForCapabilities(Capabilities capabilities, String seleniumVersion) {
248-
boolean supportsVncWithoutDebugImage = seleniumVersion.startsWith("4.");
249+
boolean supportsVncWithoutDebugImage = new ComparableVersion(seleniumVersion).isGreaterThanOrEqualTo("4");
249250

250251
String browserName;
251252
if (capabilities == null) {

0 commit comments

Comments
 (0)