Skip to content

Commit 39d1faa

Browse files
committed
Adress PR review comments
1 parent 6fc39f2 commit 39d1faa

File tree

2 files changed

+12
-29
lines changed

2 files changed

+12
-29
lines changed

modules/clickhouse/src/main/java/org/testcontainers/clickhouse/ClickHouseContainer.java

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -80,20 +80,11 @@ public Set<Integer> getLivenessCheckPortNumbers() {
8080

8181
@Override
8282
public String getDriverClassName() {
83-
84-
if (isClassLoaded(DRIVER_CLASS_NAME)) {
85-
return DRIVER_CLASS_NAME;
86-
} else {
87-
return LEGACY_V1_RIVER_CLASS_NAME;
88-
}
89-
}
90-
91-
public static boolean isClassLoaded(String driverClassName) {
9283
try {
93-
Class.forName(driverClassName);
94-
return true;
84+
Class.forName(DRIVER_CLASS_NAME);
85+
return DRIVER_CLASS_NAME;
9586
} catch (ClassNotFoundException e) {
96-
return false;
87+
return LEGACY_V1_RIVER_CLASS_NAME;
9788
}
9889
}
9990

modules/clickhouse/src/main/java/org/testcontainers/containers/ClickHouseContainer.java

Lines changed: 9 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,7 @@ public class ClickHouseContainer extends JdbcDatabaseContainer<ClickHouseContain
3333

3434
private static final String LEGACY_DRIVER_CLASS_NAME = "ru.yandex.clickhouse.ClickHouseDriver";
3535

36-
private static final String LEGACY_V1_DRIVER_CLASS_NAME = "com.clickhouse.jdbc.ClickHouseDriver";
37-
38-
private static final String DRIVER_CLASS_NAME = "com.clickhouse.jdbc.Driver";
36+
private static final String DRIVER_CLASS_NAME = "com.clickhouse.jdbc.ClickHouseDriver";
3937

4038
private static final String JDBC_URL_PREFIX = "jdbc:" + NAME + "://";
4139

@@ -81,21 +79,15 @@ public Set<Integer> getLivenessCheckPortNumbers() {
8179

8280
@Override
8381
public String getDriverClassName() {
84-
if (supportsNewDriver && isClassLoaded(DRIVER_CLASS_NAME)) {
85-
return DRIVER_CLASS_NAME;
86-
} else if (isClassLoaded(LEGACY_V1_DRIVER_CLASS_NAME)) {
87-
return LEGACY_V1_DRIVER_CLASS_NAME;
88-
} else {
89-
return LEGACY_DRIVER_CLASS_NAME;
90-
}
91-
}
92-
93-
public static boolean isClassLoaded(String driverClassName) {
9482
try {
95-
Class.forName(driverClassName);
96-
return true;
83+
if (supportsNewDriver) {
84+
Class.forName(DRIVER_CLASS_NAME);
85+
return DRIVER_CLASS_NAME;
86+
} else {
87+
return LEGACY_DRIVER_CLASS_NAME;
88+
}
9789
} catch (ClassNotFoundException e) {
98-
return false;
90+
return LEGACY_DRIVER_CLASS_NAME;
9991
}
10092
}
10193

@@ -106,7 +98,7 @@ private static boolean isNewDriverSupported(DockerImageName dockerImageName) {
10698

10799
@Override
108100
public String getJdbcUrl() {
109-
return JDBC_URL_PREFIX + getHost() + ":" + getMappedPort(HTTP_PORT) + "/" + databaseName + constructUrlParameters("?", "&");
101+
return JDBC_URL_PREFIX + getHost() + ":" + getMappedPort(HTTP_PORT) + "/" + databaseName;
110102
}
111103

112104
@Override

0 commit comments

Comments
 (0)