Skip to content

Commit 3a23d3c

Browse files
committed
update the test and the cleanup of container
1 parent 07a87da commit 3a23d3c

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

core/src/test/java/org/testcontainers/containers/ComposeContainerTest.java

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020

2121
public class ComposeContainerTest {
2222

23+
public static final String DOCKER_IMAGE = "docker:25.0.2";
2324
private TestLogAppender testLogAppender;
2425

2526
private Logger rootLogger;
@@ -30,30 +31,31 @@ public void setup() {
3031
testLogAppender.start();
3132
rootLogger = (Logger) LoggerFactory.getLogger(Logger.ROOT_LOGGER_NAME);
3233
rootLogger.addAppender(testLogAppender);
34+
TestcontainersConfiguration.getInstance().updateUserConfig("compose.container.image", DOCKER_IMAGE);
3335
}
3436

3537
@After
3638
public void tearDown() {
3739
rootLogger.detachAppender(testLogAppender);
40+
TestcontainersConfiguration.getInstance().updateUserConfig("compose.container.image", "");
41+
System.clearProperty("compose.container.image");
3842
}
3943

4044
@Test
4145
public void testWithCustomDockerImage() throws IOException {
42-
TestcontainersConfiguration.getInstance().updateUserConfig("compose.container.image", "docker:25.0.2");
4346
ComposeContainer composeContainer = new ComposeContainer(
4447
Lists.newArrayList(new File("src/test/resources/docker-compose-imagename-parsing-v2.yml"))
4548
);
4649
composeContainer.start();
47-
System.clearProperty("compose.container.image");
50+
4851
List<String> logs = testLogAppender.getLogs();
4952
composeContainer.stop();
5053
assertThat(logs).isNotNull();
5154
Optional<String> verification = logs
5255
.stream()
53-
.filter(line -> line.contains("Creating container for image: docker:25.0.2"))
56+
.filter(line -> line.contains("Creating container for image: "+DOCKER_IMAGE))
5457
.findFirst();
5558
assertThat(verification.isPresent()).isTrue();
56-
TestcontainersConfiguration.getInstance().updateUserConfig("compose.container.image", "");
5759
}
5860

5961
private static class TestLogAppender extends AppenderBase<ILoggingEvent> {
@@ -68,9 +70,5 @@ protected void append(ILoggingEvent eventObject) {
6870
public List<String> getLogs() {
6971
return logs;
7072
}
71-
72-
public void clearLogs() {
73-
logs.clear();
74-
}
7573
}
7674
}

0 commit comments

Comments
 (0)