Skip to content

Commit 3b7c2eb

Browse files
authored
Support Elastisearch image from DockerHub (#7777)
1 parent dd24851 commit 3b7c2eb

File tree

2 files changed

+21
-8
lines changed

2 files changed

+21
-8
lines changed

modules/elasticsearch/src/main/java/org/testcontainers/elasticsearch/ElasticsearchContainer.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
/**
2626
* Testcontainers implementation for Elasticsearch.
2727
* <p>
28-
* Supported image: {@code docker.elastic.co/elasticsearch/elasticsearch}
28+
* Supported image: {@code docker.elastic.co/elasticsearch/elasticsearch}, {@code elasticsearch}
2929
* <p>
3030
* Exposed ports:
3131
* <ul>
@@ -64,6 +64,8 @@ public class ElasticsearchContainer extends GenericContainer<ElasticsearchContai
6464
"docker.elastic.co/elasticsearch/elasticsearch-oss"
6565
);
6666

67+
private static final DockerImageName ELASTICSEARCH_IMAGE_NAME = DockerImageName.parse("elasticsearch");
68+
6769
/**
6870
* Elasticsearch Default version
6971
*/
@@ -100,7 +102,7 @@ public ElasticsearchContainer(String dockerImageName) {
100102
*/
101103
public ElasticsearchContainer(final DockerImageName dockerImageName) {
102104
super(dockerImageName);
103-
dockerImageName.assertCompatibleWith(DEFAULT_IMAGE_NAME, DEFAULT_OSS_IMAGE_NAME);
105+
dockerImageName.assertCompatibleWith(DEFAULT_IMAGE_NAME, DEFAULT_OSS_IMAGE_NAME, ELASTICSEARCH_IMAGE_NAME);
104106
this.isOss = dockerImageName.isCompatibleWith(DEFAULT_OSS_IMAGE_NAME);
105107

106108
withNetworkAliases("elasticsearch-" + Base58.randomString(6));

modules/elasticsearch/src/test/java/org/testcontainers/elasticsearch/ElasticsearchContainerTest.java

Lines changed: 17 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -304,9 +304,16 @@ public void testElasticsearch8SecureByDefault() throws Exception {
304304
// Start the container. This step might take some time...
305305
container.start();
306306

307-
Response response = getClusterHealth(container);
308-
assertThat(response.getStatusLine().getStatusCode()).isEqualTo(200);
309-
assertThat(EntityUtils.toString(response.getEntity())).contains("cluster_name");
307+
assertClusterHealthResponse(container);
308+
}
309+
}
310+
311+
@Test
312+
public void testDockerHubElasticsearch8ImageSecureByDefault() throws Exception {
313+
try (ElasticsearchContainer container = new ElasticsearchContainer("elasticsearch:8.1.2")) {
314+
container.start();
315+
316+
assertClusterHealthResponse(container);
310317
}
311318
}
312319

@@ -351,9 +358,7 @@ public void testElasticsearch8SecureByDefaultHttpWaitStrategy() throws Exception
351358
// Start the container. This step might take some time...
352359
container.start();
353360

354-
Response response = getClusterHealth(container);
355-
assertThat(response.getStatusLine().getStatusCode()).isEqualTo(200);
356-
assertThat(EntityUtils.toString(response.getEntity())).contains("cluster_name");
361+
assertClusterHealthResponse(container);
357362
}
358363
}
359364

@@ -488,4 +493,10 @@ private void assertElasticsearchContainerHasHeapSize(ElasticsearchContainer cont
488493
assertThat(responseBody).contains("\"heap_init_in_bytes\":" + heapSizeInBytes);
489494
assertThat(responseBody).contains("\"heap_max_in_bytes\":" + heapSizeInBytes);
490495
}
496+
497+
private void assertClusterHealthResponse(ElasticsearchContainer container) throws IOException {
498+
Response response = getClusterHealth(container);
499+
assertThat(response.getStatusLine().getStatusCode()).isEqualTo(200);
500+
assertThat(EntityUtils.toString(response.getEntity())).contains("cluster_name");
501+
}
491502
}

0 commit comments

Comments
 (0)