Skip to content

Commit 3f517a1

Browse files
authored
Move K3s tests to JUnit Jupiter (#10741)
1 parent ad84679 commit 3f517a1

File tree

3 files changed

+30
-11
lines changed

3 files changed

+30
-11
lines changed

modules/k3s/build.gradle

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,14 @@ dependencies {
66
// Synchronize with the jackson version, must match major and minor version
77
shaded 'com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.18.4'
88

9+
testRuntimeOnly 'org.junit.platform:junit-platform-launcher:1.11.0'
10+
11+
testImplementation 'org.junit.jupiter:junit-jupiter:5.13.4'
912
testImplementation 'io.fabric8:kubernetes-client:7.3.1'
1013
testImplementation 'io.kubernetes:client-java:24.0.0-legacy'
1114
testImplementation 'org.assertj:assertj-core:3.27.4'
1215
}
16+
17+
test {
18+
useJUnitPlatform()
19+
}

modules/k3s/src/test/java/org/testcontainers/k3s/Fabric8K3sContainerTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
import io.fabric8.kubernetes.client.DefaultKubernetesClient;
1313
import io.fabric8.kubernetes.client.dsl.Resource;
1414
import lombok.extern.slf4j.Slf4j;
15-
import org.junit.Test;
15+
import org.junit.jupiter.api.Test;
1616
import org.testcontainers.containers.output.Slf4jLogConsumer;
1717
import org.testcontainers.utility.DockerImageName;
1818

@@ -22,10 +22,10 @@
2222
import static org.assertj.core.api.Assertions.assertThat;
2323

2424
@Slf4j
25-
public class Fabric8K3sContainerTest {
25+
class Fabric8K3sContainerTest {
2626

2727
@Test
28-
public void shouldStartAndHaveListableNode() {
28+
void shouldStartAndHaveListableNode() {
2929
try (
3030
// starting_k3s {
3131
K3sContainer k3s = new K3sContainer(DockerImageName.parse("rancher/k3s:v1.21.3-k3s1"))

modules/k3s/src/test/java/org/testcontainers/k3s/KubectlContainerTest.java

Lines changed: 20 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
package org.testcontainers.k3s;
22

3-
import org.junit.ClassRule;
4-
import org.junit.Test;
3+
import org.junit.jupiter.api.AfterAll;
4+
import org.junit.jupiter.api.BeforeAll;
5+
import org.junit.jupiter.api.Test;
56
import org.testcontainers.containers.GenericContainer;
67
import org.testcontainers.containers.Network;
78
import org.testcontainers.containers.startupcheck.OneShotStartupCheckStrategy;
@@ -11,16 +12,26 @@
1112
import java.time.Duration;
1213

1314
import static org.assertj.core.api.Assertions.assertThat;
15+
import static org.assertj.core.api.Assertions.assertThatThrownBy;
1416

15-
public class KubectlContainerTest {
17+
class KubectlContainerTest {
1618

17-
public static Network network = Network.SHARED;
19+
private static final Network network = Network.SHARED;
1820

19-
@ClassRule
20-
public static K3sContainer k3s = new K3sContainer(DockerImageName.parse("rancher/k3s:v1.21.3-k3s1"))
21+
private static final K3sContainer k3s = new K3sContainer(DockerImageName.parse("rancher/k3s:v1.21.3-k3s1"))
2122
.withNetwork(network)
2223
.withNetworkAliases("k3s");
2324

25+
@BeforeAll
26+
static void setup() {
27+
k3s.start();
28+
}
29+
30+
@AfterAll
31+
static void teardown() {
32+
k3s.stop();
33+
}
34+
2435
@Test
2536
public void shouldExposeKubeConfigForNetworkAlias() throws Exception {
2637
String kubeConfigYaml = k3s.generateInternalKubeConfigYaml("k3s");
@@ -38,8 +49,9 @@ public void shouldExposeKubeConfigForNetworkAlias() throws Exception {
3849
}
3950
}
4051

41-
@Test(expected = IllegalArgumentException.class)
52+
@Test
4253
public void shouldThrowAnExceptionForUnknownNetworkAlias() {
43-
k3s.generateInternalKubeConfigYaml("not-set-network-alias");
54+
assertThatThrownBy(() -> k3s.generateInternalKubeConfigYaml("not-set-network-alias"))
55+
.isInstanceOf(IllegalArgumentException.class);
4456
}
4557
}

0 commit comments

Comments
 (0)