Skip to content

Commit 5d804b6

Browse files
authored
Apply suggestions from code review
1 parent 4b73ee5 commit 5d804b6

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

modules/solace/src/main/java/org/testcontainers/solace/SolaceContainer.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,7 @@ public SolaceContainer withCredentials(final String username, final String passw
254254
/**
255255
* Adds the topic configuration
256256
*
257-
* @param topic Name of the topic
257+
* @param topic Name of the topic
258258
* @param service Service to be supported on provided topic
259259
* @return This container.
260260
*/
@@ -279,7 +279,7 @@ public SolaceContainer withVpn(String vpn) {
279279
* Sets the solace server ceritificates
280280
*
281281
* @param certFile Server certificate
282-
* @param caFile Certified Authority certificate
282+
* @param caFile Certified Authority certificate
283283
* @return This container.
284284
*/
285285
public SolaceContainer withClientCert(final MountableFile certFile, final MountableFile caFile) {

modules/solace/src/test/java/org/testcontainers/solace/SolaceContainerSMFTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,12 +56,10 @@ public void testSolaceContainerWithSimpleAuthentication() {
5656
@Test
5757
public void testSolaceContainerWithCreateFlow() {
5858
try (
59-
// solaceContainerSetup {
6059
SolaceContainer solaceContainer = new SolaceContainer("solace/solace-pubsub-standard:10.25.0")
6160
.withCredentials("user", "pass")
6261
.withTopic(TOPIC.getName(), Service.SMF)
6362
.withVpn("test_vpn")
64-
// }
6563
) {
6664
solaceContainer.start();
6765
JCSMPSession session = createSessionWithBasicAuth(solaceContainer);

0 commit comments

Comments
 (0)