Skip to content

Commit 5e016c9

Browse files
author
Yannick Weber
authored
Use WaitAllStrategy for HiveMQ (#5093)
Also, remove MultiLogMessageWaitStrategy.
1 parent bfb8cec commit 5e016c9

File tree

2 files changed

+5
-68
lines changed

2 files changed

+5
-68
lines changed

core/src/main/java/org/testcontainers/containers/wait/strategy/MultiLogMessageWaitStrategy.java

Lines changed: 0 additions & 59 deletions
This file was deleted.

modules/hivemq/src/main/java/org/testcontainers/hivemq/HiveMQContainer.java

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@
88
import org.slf4j.event.Level;
99
import org.testcontainers.containers.ContainerLaunchException;
1010
import org.testcontainers.containers.GenericContainer;
11-
import org.testcontainers.containers.wait.strategy.MultiLogMessageWaitStrategy;
11+
import org.testcontainers.containers.wait.strategy.LogMessageWaitStrategy;
12+
import org.testcontainers.containers.wait.strategy.WaitAllStrategy;
1213
import org.testcontainers.utility.DockerImageName;
1314
import org.testcontainers.utility.MountableFile;
1415

@@ -48,7 +49,7 @@ public class HiveMQContainer extends GenericContainer<HiveMQContainer> {
4849
private final @NotNull Set<String> prepackagedExtensionsToRemove = new HashSet<>();
4950
private boolean removeAllPrepackagedExtensions = false;
5051

51-
private final @NotNull MultiLogMessageWaitStrategy waitStrategy = new MultiLogMessageWaitStrategy();
52+
private final @NotNull WaitAllStrategy waitStrategy = new WaitAllStrategy();
5253

5354
public HiveMQContainer(final @NotNull DockerImageName dockerImageName) {
5455
super(dockerImageName);
@@ -57,7 +58,7 @@ public HiveMQContainer(final @NotNull DockerImageName dockerImageName) {
5758

5859
addExposedPort(MQTT_PORT);
5960

60-
waitStrategy.withRegEx("(.*)Started HiveMQ in(.*)");
61+
waitStrategy.withStrategy(new LogMessageWaitStrategy().withRegEx("(.*)Started HiveMQ in(.*)"));
6162
waitingFor(waitStrategy);
6263

6364
withLogConsumer(outputFrame -> {
@@ -121,7 +122,7 @@ protected void containerIsStarted(final @NotNull InspectContainerResponse contai
121122
*/
122123
public @NotNull HiveMQContainer waitForExtension(final @NotNull String extensionName) {
123124
final String regEX = "(.*)Extension \"" + extensionName + "\" version (.*) started successfully(.*)";
124-
waitStrategy.withRegEx(regEX);
125+
waitStrategy.withStrategy(new LogMessageWaitStrategy().withRegEx(regEX));
125126
return self();
126127
}
127128

@@ -562,11 +563,6 @@ public int getMqttPort() {
562563
return this.getMappedPort(MQTT_PORT);
563564
}
564565

565-
@Override
566-
protected void containerIsStopping(final @NotNull InspectContainerResponse containerInfo) {
567-
waitStrategy.reset();
568-
}
569-
570566
private @NotNull MountableFile cloneWithFileMode(final @NotNull MountableFile mountableFile) {
571567
return MountableFile.forHostPath(mountableFile.getResolvedPath(), HiveMQContainer.MODE);
572568
}

0 commit comments

Comments
 (0)