Skip to content

Commit 6e5e6e8

Browse files
committed
Move ClickHouse tests to JUnit Jupiter
1 parent 625335a commit 6e5e6e8

File tree

4 files changed

+17
-31
lines changed

4 files changed

+17
-31
lines changed

modules/clickhouse/build.gradle

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,15 @@ dependencies {
1010
testImplementation project(':testcontainers-jdbc-test')
1111
testRuntimeOnly(group: 'com.clickhouse', name: 'clickhouse-jdbc', version: '0.9.1', classifier: 'all')
1212

13+
testRuntimeOnly 'org.junit.platform:junit-platform-launcher:1.11.0'
14+
15+
testImplementation 'org.junit.jupiter:junit-jupiter:5.13.4'
1316
testImplementation 'org.assertj:assertj-core:3.27.4'
1417
testImplementation 'com.clickhouse:client-v2:0.9.1'
1518
testImplementation testFixtures(project(':testcontainers-r2dbc'))
1619
testRuntimeOnly(group: 'com.clickhouse', name: 'clickhouse-r2dbc', version: '0.9.1', classifier: 'http')
1720
}
21+
22+
test {
23+
useJUnitPlatform()
24+
}

modules/clickhouse/src/test/java/org/testcontainers/clickhouse/ClickHouseContainerTest.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import com.clickhouse.client.api.Client;
44
import com.clickhouse.client.api.data_formats.ClickHouseBinaryFormatReader;
55
import com.clickhouse.client.api.query.QueryResponse;
6-
import org.junit.Test;
6+
import org.junit.jupiter.api.Test;
77
import org.testcontainers.ClickhouseTestImages;
88
import org.testcontainers.db.AbstractContainerDatabaseTest;
99

@@ -16,10 +16,10 @@
1616
import static org.assertj.core.api.Assertions.assertThat;
1717
import static org.assertj.core.api.Assertions.fail;
1818

19-
public class ClickHouseContainerTest extends AbstractContainerDatabaseTest {
19+
class ClickHouseContainerTest extends AbstractContainerDatabaseTest {
2020

2121
@Test
22-
public void testSimple() throws SQLException {
22+
void testSimple() throws SQLException {
2323
try ( // container {
2424
ClickHouseContainer clickhouse = new ClickHouseContainer("clickhouse/clickhouse-server:21.11-alpine")
2525
// }
@@ -34,7 +34,7 @@ public void testSimple() throws SQLException {
3434
}
3535

3636
@Test
37-
public void customCredentialsWithUrlParams() throws SQLException {
37+
void customCredentialsWithUrlParams() throws SQLException {
3838
try (
3939
ClickHouseContainer clickhouse = new ClickHouseContainer("clickhouse/clickhouse-server:21.11.2-alpine")
4040
.withUsername("default")
@@ -56,7 +56,7 @@ public void customCredentialsWithUrlParams() throws SQLException {
5656
}
5757

5858
@Test
59-
public void testNewAuth() throws SQLException {
59+
void testNewAuth() throws SQLException {
6060
try (ClickHouseContainer clickhouse = new ClickHouseContainer(ClickhouseTestImages.CLICKHOUSE_24_12_IMAGE)) {
6161
clickhouse.start();
6262

@@ -68,7 +68,7 @@ public void testNewAuth() throws SQLException {
6868
}
6969

7070
@Test
71-
public void testGetHttpMethodWithHttpClient() {
71+
void testGetHttpMethodWithHttpClient() {
7272
ClickHouseContainer clickhouse = new ClickHouseContainer(ClickhouseTestImages.CLICKHOUSE_24_12_IMAGE);
7373
clickhouse.start();
7474
Client client = new Client.Builder()

modules/clickhouse/src/test/java/org/testcontainers/jdbc/clickhouse/ClickhouseJDBCDriverTest.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,12 @@
11
package org.testcontainers.jdbc.clickhouse;
22

3-
import org.junit.runner.RunWith;
4-
import org.junit.runners.Parameterized;
53
import org.testcontainers.jdbc.AbstractJDBCDriverTest;
64

75
import java.util.Arrays;
86
import java.util.EnumSet;
97

10-
@RunWith(Parameterized.class)
11-
public class ClickhouseJDBCDriverTest extends AbstractJDBCDriverTest {
8+
class ClickhouseJDBCDriverTest extends AbstractJDBCDriverTest {
129

13-
@Parameterized.Parameters(name = "{index} - {0}")
1410
public static Iterable<Object[]> data() {
1511
return Arrays.asList(
1612
new Object[][] { //

modules/clickhouse/src/test/java/org/testcontainers/junit/clickhouse/SimpleClickhouseTest.java

Lines changed: 3 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,37 +1,20 @@
11
package org.testcontainers.junit.clickhouse;
22

3-
import org.junit.Test;
4-
import org.junit.runner.RunWith;
5-
import org.junit.runners.Parameterized;
3+
import org.junit.jupiter.api.Test;
64
import org.testcontainers.ClickhouseTestImages;
75
import org.testcontainers.containers.ClickHouseContainer;
86
import org.testcontainers.db.AbstractContainerDatabaseTest;
9-
import org.testcontainers.utility.DockerImageName;
107

118
import java.sql.ResultSet;
129
import java.sql.SQLException;
1310

1411
import static org.assertj.core.api.Assertions.assertThat;
1512

16-
@RunWith(Parameterized.class)
17-
public class SimpleClickhouseTest extends AbstractContainerDatabaseTest {
18-
19-
private final DockerImageName imageName;
20-
21-
public SimpleClickhouseTest(DockerImageName imageName) {
22-
this.imageName = imageName;
23-
}
24-
25-
@Parameterized.Parameters(name = "{0}")
26-
public static Object[][] data() {
27-
return new Object[][] { //
28-
{ ClickhouseTestImages.CLICKHOUSE_IMAGE },
29-
};
30-
}
13+
class SimpleClickhouseTest extends AbstractContainerDatabaseTest {
3114

3215
@Test
3316
public void testSimple() throws SQLException {
34-
try (ClickHouseContainer clickhouse = new ClickHouseContainer(this.imageName)) {
17+
try (ClickHouseContainer clickhouse = new ClickHouseContainer(ClickhouseTestImages.CLICKHOUSE_IMAGE)) {
3518
clickhouse.start();
3619

3720
ResultSet resultSet = performQuery(clickhouse, "SELECT 1");

0 commit comments

Comments
 (0)