no api scope for junit4

panchenko · panchenko · commit 74d21717225f · 2025-05-30T17:20:06.000+02:00
diff --git a/build.gradle b/build.gradle
@@ -132,6 +132,11 @@ subprojects {
 
     dependencies {
         testImplementation 'ch.qos.logback:logback-classic:1.3.14'
+
+        if (project.path != ':testcontainers') {
+            // for compiling classes which extend GenericContainer, etc
+            compileOnly 'junit:junit:4.13.2'
+        }
     }
 
     checkstyle {
diff --git a/core/build.gradle b/core/build.gradle
@@ -69,7 +69,7 @@ configurations.all {
 }
 
 dependencies {
-    api 'junit:junit:4.13.2'
+    implementation 'junit:junit:4.13.2' // originally had api scope
     api 'org.slf4j:slf4j-api:1.7.36'
     compileOnly 'org.jetbrains:annotations:24.1.0'
     testCompileOnly 'org.jetbrains:annotations:24.1.0'

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ configurations.all {`
`69`	`69`	`}`
`70`	`70`
`71`	`71`	`dependencies {`
`72`		`- api 'junit:junit:4.13.2'`
	`72`	`+ implementation 'junit:junit:4.13.2' // originally had api scope`
`73`	`73`	`api 'org.slf4j:slf4j-api:1.7.36'`
`74`	`74`	`compileOnly 'org.jetbrains:annotations:24.1.0'`
`75`	`75`	`testCompileOnly 'org.jetbrains:annotations:24.1.0'`