Skip to content

Commit 77738d8

Browse files
authored
Remove org.testcontainers.neo4j.Neo4jContainer#withEnterpriseEdition (#11106)
1 parent 16d93e3 commit 77738d8

File tree

2 files changed

+5
-43
lines changed

2 files changed

+5
-43
lines changed

modules/neo4j/src/main/java/org/testcontainers/neo4j/Neo4jContainer.java

Lines changed: 3 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import org.testcontainers.containers.wait.strategy.WaitStrategy;
88
import org.testcontainers.utility.ComparableVersion;
99
import org.testcontainers.utility.DockerImageName;
10-
import org.testcontainers.utility.LicenseAcceptance;
1110
import org.testcontainers.utility.MountableFile;
1211

1312
import java.net.HttpURLConnection;
@@ -39,13 +38,6 @@ public class Neo4jContainer extends GenericContainer<Neo4jContainer> {
3938
*/
4039
private static final DockerImageName DEFAULT_IMAGE_NAME = DockerImageName.parse("neo4j");
4140

42-
/**
43-
* The default tag (version) to use.
44-
*/
45-
private static final String DEFAULT_TAG = "4.4";
46-
47-
private static final String ENTERPRISE_TAG = DEFAULT_TAG + "-enterprise";
48-
4941
/**
5042
* Default port for the binary Bolt protocol.
5143
*/
@@ -68,8 +60,6 @@ public class Neo4jContainer extends GenericContainer<Neo4jContainer> {
6860

6961
private static final String AUTH_FORMAT = "neo4j/%s";
7062

71-
private final boolean standardImage;
72-
7363
private String adminPassword = DEFAULT_ADMIN_PASSWORD;
7464

7565
private final Set<String> labsPlugins = new HashSet<>();
@@ -100,8 +90,6 @@ public Neo4jContainer(String dockerImageName) {
10090
*/
10191
public Neo4jContainer(final DockerImageName dockerImageName) {
10292
super(dockerImageName);
103-
this.standardImage = dockerImageName.getUnversionedPart().equals(DEFAULT_IMAGE_NAME.getUnversionedPart());
104-
10593
dockerImageName.assertCompatibleWith(DEFAULT_IMAGE_NAME);
10694

10795
waitingFor(
@@ -197,26 +185,12 @@ public String getHttpsUrl() {
197185
}
198186

199187
/**
200-
* Configures the container to use the enterprise edition of the default docker image.
201-
* <br><br>
202-
* Please have a look at the <a href="https://neo4j.com/licensing/">Neo4j Licensing page</a>. While the Neo4j
203-
* Community Edition can be used for free in your projects under the GPL v3 license, Neo4j Enterprise edition
204-
* needs either a commercial, education or evaluation license.
188+
* Accepts the license agreement of the container.
205189
*
206-
* @return This container.
190+
* @return this
207191
*/
208-
public Neo4jContainer withEnterpriseEdition() {
209-
if (!standardImage) {
210-
throw new IllegalStateException(
211-
String.format("Cannot use enterprise version with alternative image %s.", getDockerImageName())
212-
);
213-
}
214-
215-
setDockerImageName(DEFAULT_IMAGE_NAME.withTag(ENTERPRISE_TAG).asCanonicalNameString());
216-
LicenseAcceptance.assertLicenseAccepted(getDockerImageName());
217-
192+
public Neo4jContainer acceptLicense() {
218193
addEnv("NEO4J_ACCEPT_LICENSE_AGREEMENT", "yes");
219-
220194
return self();
221195
}
222196

modules/neo4j/src/test/java/org/testcontainers/neo4j/Neo4jContainerTest.java

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
import java.util.UUID;
2222

2323
import static org.assertj.core.api.Assertions.assertThat;
24-
import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
2524
import static org.assertj.core.api.Assertions.assertThatIllegalArgumentException;
2625
import static org.assertj.core.api.Assertions.assertThatNoException;
2726
import static org.assertj.core.api.Assumptions.assumeThat;
@@ -132,25 +131,14 @@ private static void assertThatCustomPluginWasCopied(Session session) {
132131
assertThat(singleRecord.get("greeting").asString()).isEqualTo("Hello, Testcontainers");
133132
}
134133

135-
@Test
136-
void shouldCheckEnterpriseLicense() {
137-
assumeThat(Neo4jContainerTest.class.getResource(ACCEPTANCE_FILE_LOCATION)).isNull();
138-
139-
String expectedImageName = "neo4j:4.4-enterprise";
140-
141-
assertThatExceptionOfType(IllegalStateException.class)
142-
.isThrownBy(() -> new Neo4jContainer("neo4j:4.4").withEnterpriseEdition())
143-
.withMessageContaining("The image " + expectedImageName + " requires you to accept a license agreement.");
144-
}
145-
146134
@Test
147135
void shouldRunEnterprise() {
148136
assumeThat(Neo4jContainerTest.class.getResource(ACCEPTANCE_FILE_LOCATION)).isNotNull();
149137

150138
try (
151139
// enterpriseEdition {
152-
Neo4jContainer neo4jContainer = new Neo4jContainer("neo4j:4.4")
153-
.withEnterpriseEdition()
140+
Neo4jContainer neo4jContainer = new Neo4jContainer("neo4j:4.4-enterprise")
141+
.acceptLicense()
154142
// }
155143
.withAdminPassword("Picard123")
156144
) {

0 commit comments

Comments
 (0)