Skip to content

Commit 780b97c

Browse files
committed
Remove deprecated API usage from examples.
1 parent a212109 commit 780b97c

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

docs/examples/junit4/generic/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,6 @@ dependencies {
77
testImplementation project(":mysql")
88

99
testImplementation 'mysql:mysql-connector-java:8.0.21'
10-
testImplementation "org.seleniumhq.selenium:selenium-api:3.141.59"
10+
testImplementation 'org.seleniumhq.selenium:selenium-java:4.0.0'
1111
testImplementation 'org.assertj:assertj-core:3.15.0'
1212
}

docs/examples/junit4/generic/src/test/java/generic/HostPortExposedTest.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,11 @@
99
import org.openqa.selenium.remote.RemoteWebDriver;
1010
import org.testcontainers.Testcontainers;
1111
import org.testcontainers.containers.BrowserWebDriverContainer;
12+
import org.testcontainers.utility.DockerImageName;
1213

1314
import java.io.OutputStream;
1415
import java.net.InetSocketAddress;
16+
import java.net.URL;
1517

1618
import static org.junit.Assert.assertTrue;
1719

@@ -46,7 +48,7 @@ public static void tearDown() throws Exception {
4648
}
4749

4850
@Rule
49-
public BrowserWebDriverContainer browser = new BrowserWebDriverContainer()
51+
public BrowserWebDriverContainer<?> browser = new BrowserWebDriverContainer<>("selenium/standalone-chrome:4")
5052
.withCapabilities(new ChromeOptions());
5153

5254
@Test
@@ -55,7 +57,8 @@ public void testContainerRunningAgainstExposedHostPort() {
5557
final String rootUrl =
5658
String.format("http://host.testcontainers.internal:%d/", localServerPort);
5759

58-
final RemoteWebDriver webDriver = browser.getWebDriver();
60+
URL seleniumAddress = browser.getSeleniumAddress();
61+
RemoteWebDriver webDriver = new RemoteWebDriver(seleniumAddress, new ChromeOptions());
5962
webDriver.get(rootUrl);
6063
// }
6164

modules/selenium/src/main/java/org/testcontainers/containers/BrowserWebDriverContainer.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -98,10 +98,7 @@ public BrowserWebDriverContainer() {
9898
/**
9999
* Constructor taking a specific webdriver container name and tag
100100
* @param dockerImageName Name of the selenium docker image
101-
*
102-
* @deprecated please use {@link BrowserWebDriverContainer#BrowserWebDriverContainer(DockerImageName)}
103101
*/
104-
@Deprecated
105102
public BrowserWebDriverContainer(String dockerImageName) {
106103
this(DockerImageName.parse(dockerImageName));
107104
}

0 commit comments

Comments
 (0)