Skip to content

Commit 7d25104

Browse files
committed
chore: migrate test code to JUnit5
1 parent 359df69 commit 7d25104

File tree

281 files changed

+1238
-1045
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

281 files changed

+1238
-1045
lines changed

core/src/jarFileTest/java/org/testcontainers/PublicBinaryAPITest.java

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,10 @@
22

33
import lombok.RequiredArgsConstructor;
44
import org.assertj.core.api.Assertions;
5-
import org.junit.Assume;
6-
import org.junit.Before;
7-
import org.junit.Test;
8-
import org.junit.runner.RunWith;
9-
import org.junit.runners.Parameterized;
10-
import org.junit.runners.Parameterized.Parameters;
5+
import org.junit.jupiter.api.BeforeEach;
6+
import org.junit.jupiter.api.Test;
7+
import org.junit.jupiter.params.ParameterizedClass;
8+
import org.junit.jupiter.params.provider.MethodSource;
119
import org.objectweb.asm.ClassReader;
1210
import org.objectweb.asm.Opcodes;
1311
import org.objectweb.asm.Type;
@@ -27,12 +25,13 @@
2725
import java.util.List;
2826

2927
import static org.assertj.core.api.Assertions.assertThat;
28+
import static org.assertj.core.api.Assumptions.assumeThat;
3029

3130
/**
3231
* This test checks that we don't expose any shaded class in our public API.
33-
* We use {@link Parameterized} runner here to create a test per public class in Testcontainers' JAR file.
3432
*/
35-
@RunWith(Parameterized.class)
33+
@ParameterizedClass
34+
@MethodSource("data")
3635
@RequiredArgsConstructor
3736
public class PublicBinaryAPITest extends AbstractJarFileTest {
3837

@@ -46,7 +45,6 @@ public class PublicBinaryAPITest extends AbstractJarFileTest {
4645
Assertions.registerFormatterForType(MethodNode.class, it -> it.name + it.desc);
4746
}
4847

49-
@Parameters(name = "{0}")
5048
public static List<Object[]> data() throws Exception {
5149
List<Object[]> result = new ArrayList<>();
5250

@@ -89,15 +87,15 @@ public FileVisitResult visitFile(Path path, BasicFileAttributes attrs) throws IO
8987

9088
private final ClassNode classNode;
9189

92-
@Before
90+
@BeforeEach
9391
public void setUp() {
9492
switch (classNode.name) {
9593
// Necessary evil
9694
case "org/testcontainers/dockerclient/UnixSocketClientProviderStrategy":
9795
case "org/testcontainers/dockerclient/DockerClientProviderStrategy":
9896
case "org/testcontainers/dockerclient/WindowsClientProviderStrategy":
9997
case "org/testcontainers/utility/DynamicPollInterval":
100-
Assume.assumeTrue(false);
98+
assumeThat(true).isFalse();
10199
}
102100
}
103101

core/src/test/java/alt/testcontainers/images/OutOfPackageImagePullPolicyTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package alt.testcontainers.images;
22

3-
import org.junit.Test;
3+
import org.junit.jupiter.api.Test;
44
import org.testcontainers.TestImages;
55
import org.testcontainers.containers.GenericContainer;
66
import org.testcontainers.containers.startupcheck.OneShotStartupCheckStrategy;

core/src/test/java/org/testcontainers/DaemonTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package org.testcontainers;
22

3-
import org.junit.Test;
3+
import org.junit.jupiter.api.Test;
44
import org.testcontainers.containers.GenericContainer;
55

66
import java.io.File;

core/src/test/java/org/testcontainers/DockerClientFactoryTest.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
package org.testcontainers;
22

3-
import org.junit.Rule;
4-
import org.junit.Test;
3+
import org.junit.jupiter.api.Test;
54
import org.testcontainers.dockerclient.LogToStringContainerCallback;
5+
import org.testcontainers.junit.jupiter.Container;
6+
import org.testcontainers.junit.jupiter.Testcontainers;
67
import org.testcontainers.utility.DockerImageName;
78
import org.testcontainers.utility.MockTestcontainersConfigurationRule;
89

@@ -12,9 +13,10 @@
1213
/**
1314
* Test for {@link DockerClientFactory}.
1415
*/
16+
@Testcontainers
1517
public class DockerClientFactoryTest {
1618

17-
@Rule
19+
@Container
1820
public MockTestcontainersConfigurationRule configurationMock = new MockTestcontainersConfigurationRule();
1921

2022
@Test

core/src/test/java/org/testcontainers/containers/ComposeContainerWithServicesTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package org.testcontainers.containers;
22

3-
import org.junit.Test;
3+
import org.junit.jupiter.api.Test;
44
import org.rnorth.ducttape.TimeoutException;
55
import org.testcontainers.containers.wait.strategy.Wait;
66

core/src/test/java/org/testcontainers/containers/ComposeOverridesTest.java

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,10 @@
33
import com.google.common.util.concurrent.Uninterruptibles;
44
import org.apache.commons.lang3.SystemUtils;
55
import org.assertj.core.api.Assumptions;
6-
import org.junit.Before;
7-
import org.junit.Test;
8-
import org.junit.runner.RunWith;
9-
import org.junit.runners.Parameterized;
10-
import org.junit.runners.Parameterized.Parameters;
6+
import org.junit.jupiter.api.BeforeEach;
7+
import org.junit.jupiter.api.Test;
8+
import org.junit.jupiter.params.ParameterizedClass;
9+
import org.junit.jupiter.params.provider.MethodSource;
1110
import org.rnorth.ducttape.unreliables.Unreliables;
1211
import org.testcontainers.utility.CommandLine;
1312

@@ -18,7 +17,8 @@
1817
import java.util.Arrays;
1918
import java.util.concurrent.TimeUnit;
2019

21-
@RunWith(Parameterized.class)
20+
@ParameterizedClass(name = "{index}: local[{0}], composeFiles[{2}], expectedEnvVar[{1}]")
21+
@MethodSource("data")
2222
public class ComposeOverridesTest {
2323

2424
private static final String DOCKER_EXECUTABLE = SystemUtils.IS_OS_WINDOWS ? "docker.exe" : "docker";
@@ -49,7 +49,6 @@ public ComposeOverridesTest(boolean localMode, String expectedEnvVar, File... co
4949
this.composeFiles = composeFiles;
5050
}
5151

52-
@Parameters(name = "{index}: local[{0}], composeFiles[{2}], expectedEnvVar[{1}]")
5352
public static Iterable<Object[]> data() {
5453
return Arrays.asList(
5554
new Object[][] {
@@ -61,7 +60,7 @@ public static Iterable<Object[]> data() {
6160
);
6261
}
6362

64-
@Before
63+
@BeforeEach
6564
public void setUp() {
6665
if (localMode) {
6766
Assumptions

core/src/test/java/org/testcontainers/containers/ComposeProfilesOptionTest.java

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,32 @@
11
package org.testcontainers.containers;
22

33
import org.assertj.core.api.Assumptions;
4-
import org.junit.Before;
5-
import org.junit.Test;
4+
import org.junit.jupiter.api.BeforeEach;
5+
import org.junit.jupiter.api.Test;
6+
import org.junit.jupiter.params.Parameter;
7+
import org.junit.jupiter.params.ParameterizedClass;
8+
import org.junit.jupiter.params.provider.MethodSource;
69
import org.junit.runner.RunWith;
7-
import org.junit.runners.Parameterized;
810
import org.testcontainers.utility.CommandLine;
911

1012
import java.io.File;
1113

1214
import static org.assertj.core.api.Assertions.assertThat;
1315

14-
@RunWith(Parameterized.class)
16+
@ParameterizedClass
17+
@MethodSource("local")
1518
public class ComposeProfilesOptionTest {
1619

17-
@Parameterized.Parameters(name = "{0}")
1820
public static Boolean[] local() {
1921
return new Boolean[] { Boolean.TRUE, Boolean.FALSE };
2022
}
2123

22-
@Parameterized.Parameter
24+
@Parameter(0)
2325
public boolean localMode;
2426

2527
public static final File COMPOSE_FILE = new File("src/test/resources/compose-profile-option/compose-test.yml");
2628

27-
@Before
29+
@BeforeEach
2830
public void setUp() {
2931
if (this.localMode) {
3032
Assumptions

core/src/test/java/org/testcontainers/containers/ContainerStateTest.java

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
package org.testcontainers.containers;
22

3-
import org.junit.Test;
4-
import org.junit.runner.RunWith;
5-
import org.junit.runners.Parameterized;
3+
import org.junit.jupiter.api.Test;
4+
import org.junit.jupiter.params.Parameter;
5+
import org.junit.jupiter.params.ParameterizedClass;
6+
import org.junit.jupiter.params.provider.MethodSource;
67

78
import java.util.Collections;
89
import java.util.List;
@@ -12,10 +13,10 @@
1213
import static org.mockito.Mockito.mock;
1314
import static org.mockito.Mockito.when;
1415

15-
@RunWith(Parameterized.class)
16+
@ParameterizedClass(name = "{0} ({1} -> {2})")
17+
@MethodSource("params")
1618
public class ContainerStateTest {
1719

18-
@Parameterized.Parameters(name = "{0} ({1} -> {2})")
1920
public static Object[][] params() {
2021
return new Object[][] {
2122
new Object[] { "regular mapping", "80:8080/tcp", Collections.singletonList(80) },
@@ -27,13 +28,13 @@ public static Object[][] params() {
2728
};
2829
}
2930

30-
@Parameterized.Parameter(0)
31+
@Parameter(0)
3132
public String name;
3233

33-
@Parameterized.Parameter(1)
34+
@Parameter(1)
3435
public String testSet;
3536

36-
@Parameterized.Parameter(2)
37+
@Parameter(2)
3738
public List<Integer> expectedResult;
3839

3940
@Test

core/src/test/java/org/testcontainers/containers/DockerComposeContainerWithServicesTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package org.testcontainers.containers;
22

3-
import org.junit.Test;
3+
import org.junit.jupiter.api.Test;
44
import org.rnorth.ducttape.TimeoutException;
55
import org.testcontainers.containers.wait.strategy.Wait;
66

core/src/test/java/org/testcontainers/containers/DockerComposeFilesTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package org.testcontainers.containers;
22

33
import com.google.common.collect.Lists;
4-
import org.junit.Test;
4+
import org.junit.jupiter.api.Test;
55

66
import java.io.File;
77

0 commit comments

Comments
 (0)