Skip to content

Commit 820161f

Browse files
Added started log message used in Selenium 4.0.0 (#4580)
1 parent e257bac commit 820161f

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

modules/selenium/src/main/java/org/testcontainers/containers/BrowserWebDriverContainer.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ public class BrowserWebDriverContainer<SELF extends BrowserWebDriverContainer<SE
7878
public BrowserWebDriverContainer() {
7979
super();
8080
final WaitStrategy logWaitStrategy = new LogMessageWaitStrategy()
81-
.withRegEx(".*(RemoteWebDriver instances should connect to|Selenium Server is up and running).*\n")
81+
.withRegEx(".*(RemoteWebDriver instances should connect to|Selenium Server is up and running|Started Selenium Standalone).*\n")
8282
.withStartupTimeout(Duration.of(15, SECONDS));
8383

8484
this.waitStrategy = new WaitAllStrategy()
@@ -107,7 +107,7 @@ public BrowserWebDriverContainer(DockerImageName dockerImageName) {
107107
// we assert compatibility with the chrome/firefox image later, after capabilities are processed
108108

109109
final WaitStrategy logWaitStrategy = new LogMessageWaitStrategy()
110-
.withRegEx(".*(RemoteWebDriver instances should connect to|Selenium Server is up and running).*\n")
110+
.withRegEx(".*(RemoteWebDriver instances should connect to|Selenium Server is up and running|Started Selenium Standalone).*\n")
111111
.withStartupTimeout(Duration.of(15, SECONDS));
112112

113113
this.waitStrategy = new WaitAllStrategy()

modules/selenium/src/test/java/org/testcontainers/junit/Selenium3xTest.java renamed to modules/selenium/src/test/java/org/testcontainers/junit/SeleniumStartTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,11 @@
1111
* Simple test to check that readiness detection works correctly across major versions of the containers.
1212
*/
1313
@RunWith(Parameterized.class)
14-
public class Selenium3xTest {
14+
public class SeleniumStartTest {
1515

1616
@Parameterized.Parameters(name = "tag: {0}")
1717
public static String[] data() {
18-
return new String[]{"3.4.0", "2.53.0", "2.45.0"};
18+
return new String[]{"4.0.0", "3.4.0", "2.53.0", "2.45.0"};
1919
}
2020

2121
@Parameterized.Parameter()
@@ -24,7 +24,7 @@ public static String[] data() {
2424
@Test
2525
public void testAdditionalStartupString() {
2626
final DockerImageName imageName = DockerImageName
27-
.parse("selenium/standalone-chrome-debug")
27+
.parse("selenium/standalone-chrome")
2828
.withTag(tag);
2929
try (BrowserWebDriverContainer<?> chrome = new BrowserWebDriverContainer<>(imageName)
3030
.withCapabilities(new ChromeOptions())) {

0 commit comments

Comments
 (0)