Refactor query execution to use performSelectMaxConnectionsQuery method for consistency

Author: raju.gupta

modules/jdbc-test/src/main/java/org/testcontainers/db/AbstractContainerDatabaseTest.java

@@ -65,6 +65,21 @@ protected void performSelectFooBarQuery(final JdbcDatabaseContainer<?> container
         );
     }
 
+    protected void performSelectMaxConnectionsQuery(final JdbcDatabaseContainer<?> container) throws SQLException {
+        performQuery(
+            container,
+            "SELECT current_setting('max_connections')",
+            resultSet -> {
+                Assertions
+                    .assertThatNoException()
+                    .isThrownBy(() -> {
+                        String result = resultSet.getString(1);
+                        Assertions.assertThat(result).as("max_connections should be overridden").isEqualTo("42");
+                    });
+            }
+        );
+    }
+
     protected DataSource getDataSource(final JdbcDatabaseContainer<?> container) {
         HikariConfig hikariConfig = new HikariConfig();
         hikariConfig.setJdbcUrl(container.getJdbcUrl());

modules/postgresql/src/test/java/org/testcontainers/containers/TimescaleDBContainerTest.java

@@ -1,13 +1,10 @@
 package org.testcontainers.containers;
 
-import org.assertj.core.api.Assertions;
 import org.junit.jupiter.api.Test;
 import org.testcontainers.db.AbstractContainerDatabaseTest;
 
 import java.sql.SQLException;
 
-import static org.assertj.core.api.Assertions.assertThat;
-
 class TimescaleDBContainerTest extends AbstractContainerDatabaseTest {
 
     @Test
@@ -28,18 +25,7 @@ void testCommandOverride() throws SQLException {
         ) {
             postgres.start();
 
-            performQuery(
-                (JdbcDatabaseContainer<?>) postgres,
-                "SELECT current_setting('max_connections')",
-                resultSet -> {
-                    Assertions
-                        .assertThatNoException()
-                        .isThrownBy(() -> {
-                            String result = resultSet.getString(1);
-                            assertThat(result).as("max_connections should be overridden").isEqualTo("42");
-                        });
-                }
-            );
+            performSelectMaxConnectionsQuery((JdbcDatabaseContainer<?>) postgres);
         }
     }
 
@@ -53,18 +39,7 @@ void testUnsetCommand() throws SQLException {
         ) {
             postgres.start();
 
-            performQuery(
-                (JdbcDatabaseContainer<?>) postgres,
-                "SELECT current_setting('max_connections')",
-                resultSet -> {
-                    Assertions
-                        .assertThatNoException()
-                        .isThrownBy(() -> {
-                            String result = resultSet.getString(1);
-                            assertThat(result).as("max_connections should not be overridden").isNotEqualTo("42");
-                        });
-                }
-            );
+            performSelectMaxConnectionsQuery((JdbcDatabaseContainer<?>) postgres);
         }
     }
 

modules/postgresql/src/test/java/org/testcontainers/postgresql/PostgreSQLContainerTest.java

@@ -40,18 +40,7 @@ void testCommandOverride() throws SQLException {
         ) {
             postgres.start();
 
-            performQuery(
-                postgres,
-                "SELECT current_setting('max_connections')",
-                resultSet -> {
-                    Assertions
-                        .assertThatNoException()
-                        .isThrownBy(() -> {
-                            String result = resultSet.getString(1);
-                            assertThat(result).as("max_connections should be overridden").isEqualTo("42");
-                        });
-                }
-            );
+            performSelectMaxConnectionsQuery(postgres);
         }
     }
 
@@ -64,18 +53,7 @@ void testUnsetCommand() throws SQLException {
         ) {
             postgres.start();
 
-            performQuery(
-                postgres,
-                "SELECT current_setting('max_connections')",
-                resultSet -> {
-                    Assertions
-                        .assertThatNoException()
-                        .isThrownBy(() -> {
-                            String result = resultSet.getString(1);
-                            assertThat(result).as("max_connections should not be overridden").isNotEqualTo("42");
-                        });
-                }
-            );
+            performSelectMaxConnectionsQuery(postgres);
         }
     }