Remember failure to ping docker daemon to reduce log garbage and reduce run time (#456)

Author: rnorth

CHANGELOG.md

@@ -2,6 +2,9 @@
 All notable changes to this project will be documented in this file.
 
 ## UNRELEASED
+### Changed
+- Added caching of failure to find a docker daemon, so that subsequent tests fail fast. This is likely to be a significant improvement in situations where there is no docker daemon available, dramatically reducing run time and log output when further attempts to find the docker daemon cannot succeed.
+
 ### Fixed
 - Fixed local Docker Compose executable name resolution on Windows (#416)
 - Fix TAR composition on Windows (#444)

core/src/main/java/org/testcontainers/dockerclient/DockerClientProviderStrategy.java

@@ -20,6 +20,7 @@
 import java.util.List;
 import java.util.Objects;
 import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
 import java.util.stream.Stream;
 
 /**
@@ -35,6 +36,8 @@ public abstract class DockerClientProviderStrategy {
             .withConstantThroughput()
             .build();
 
+    private static final AtomicBoolean FAIL_FAST_ALWAYS = new AtomicBoolean(false);
+
     /**
      * @throws InvalidConfigurationException if this strategy fails
      */
@@ -64,6 +67,11 @@ protected int getPriority() {
      * @return a working DockerClientConfig, as determined by successful execution of a ping command
      */
     public static DockerClientProviderStrategy getFirstValidStrategy(List<DockerClientProviderStrategy> strategies) {
+
+        if (FAIL_FAST_ALWAYS.get()) {
+            throw new IllegalStateException("Previous attempts to find a Docker environment failed. Will not retry. Please see logs and check configuration");
+        }
+
         List<String> configurationFailures = new ArrayList<>();
 
         return Stream
@@ -134,6 +142,7 @@ public static DockerClientProviderStrategy getFirstValidStrategy(List<DockerClie
                     }
                     LOGGER.error("As no valid configuration was found, execution cannot continue");
 
+                    FAIL_FAST_ALWAYS.set(true);
                     return new IllegalStateException("Could not find a valid Docker environment. Please see logs and check configuration");
                 });
     }