Skip to content

Commit aae4f64

Browse files
authored
Move MockServer tests to JUnit Jupiter (#10749)
1 parent a3cff71 commit aae4f64

File tree

3 files changed

+30
-13
lines changed

3 files changed

+30
-13
lines changed

modules/mockserver/build.gradle

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,9 @@ description = "Testcontainers :: MockServer"
33
dependencies {
44
api project(':testcontainers')
55

6+
testRuntimeOnly 'org.junit.platform:junit-platform-launcher:1.11.0'
7+
8+
testImplementation 'org.junit.jupiter:junit-jupiter:5.13.4'
69
testImplementation 'org.mock-server:mockserver-client-java:5.15.0'
710
testImplementation 'org.assertj:assertj-core:3.27.4'
811
testImplementation 'io.rest-assured:rest-assured:5.5.6'
@@ -13,3 +16,7 @@ tasks.japicmp {
1316
"org.testcontainers.containers.MockServerContainer"
1417
]
1518
}
19+
20+
test {
21+
useJUnitPlatform()
22+
}

modules/mockserver/src/test/java/org/testcontainers/containers/MockServerContainerRuleTest.java

Lines changed: 17 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
package org.testcontainers.containers;
22

3-
import org.junit.Rule;
4-
import org.junit.Test;
3+
import org.junit.jupiter.api.AfterAll;
4+
import org.junit.jupiter.api.BeforeAll;
5+
import org.junit.jupiter.api.Test;
56
import org.mockserver.client.MockServerClient;
67
import org.testcontainers.utility.DockerImageName;
78

@@ -10,20 +11,29 @@
1011
import static org.mockserver.model.HttpRequest.request;
1112
import static org.mockserver.model.HttpResponse.response;
1213

13-
public class MockServerContainerRuleTest {
14+
class MockServerContainerRuleTest {
1415

1516
// creatingProxy {
16-
public static final DockerImageName MOCKSERVER_IMAGE = DockerImageName
17+
private static final DockerImageName MOCKSERVER_IMAGE = DockerImageName
1718
.parse("mockserver/mockserver")
1819
.withTag("mockserver-" + MockServerClient.class.getPackage().getImplementationVersion());
1920

20-
@Rule
21-
public MockServerContainer mockServer = new MockServerContainer(MOCKSERVER_IMAGE);
21+
private static MockServerContainer mockServer = new MockServerContainer(MOCKSERVER_IMAGE);
2222

2323
// }
2424

25+
@BeforeAll
26+
static void setup() {
27+
mockServer.start();
28+
}
29+
30+
@AfterAll
31+
static void tearDown() {
32+
mockServer.stop();
33+
}
34+
2535
@Test
26-
public void shouldReturnExpectation() throws Exception {
36+
void shouldReturnExpectation() {
2737
// testSimpleExpectation {
2838
try (
2939
MockServerClient mockServerClient = new MockServerClient(mockServer.getHost(), mockServer.getServerPort())

modules/mockserver/src/test/java/org/testcontainers/containers/MockServerContainerTest.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import io.restassured.config.RestAssuredConfig;
44
import io.restassured.config.SSLConfig;
55
import org.apache.http.conn.ssl.SSLSocketFactory;
6-
import org.junit.Test;
6+
import org.junit.jupiter.api.Test;
77
import org.mockserver.client.MockServerClient;
88
import org.mockserver.configuration.Configuration;
99
import org.mockserver.logging.MockServerLogger;
@@ -15,14 +15,14 @@
1515
import static org.mockserver.model.HttpRequest.request;
1616
import static org.mockserver.model.HttpResponse.response;
1717

18-
public class MockServerContainerTest {
18+
class MockServerContainerTest {
1919

2020
public static final DockerImageName MOCKSERVER_IMAGE = DockerImageName
2121
.parse("mockserver/mockserver")
2222
.withTag("mockserver-" + MockServerClient.class.getPackage().getImplementationVersion());
2323

2424
@Test
25-
public void shouldCallActualMockserverVersion() throws Exception {
25+
void shouldCallActualMockserverVersion() throws Exception {
2626
try (MockServerContainer mockServer = new MockServerContainer(MOCKSERVER_IMAGE)) {
2727
mockServer.start();
2828

@@ -41,7 +41,7 @@ public void shouldCallActualMockserverVersion() throws Exception {
4141
}
4242

4343
@Test
44-
public void shouldCallMockserverUsingTlsProtocol() throws Exception {
44+
void shouldCallMockserverUsingTlsProtocol() throws Exception {
4545
try (MockServerContainer mockServer = new MockServerContainer(MOCKSERVER_IMAGE)) {
4646
mockServer.start();
4747

@@ -63,7 +63,7 @@ public void shouldCallMockserverUsingTlsProtocol() throws Exception {
6363
}
6464

6565
@Test
66-
public void shouldCallMockserverUsingMutualTlsProtocol() throws Exception {
66+
void shouldCallMockserverUsingMutualTlsProtocol() throws Exception {
6767
try (
6868
MockServerContainer mockServer = new MockServerContainer(MOCKSERVER_IMAGE)
6969
.withEnv("MOCKSERVER_TLS_MUTUAL_AUTHENTICATION_REQUIRED", "true")
@@ -88,7 +88,7 @@ public void shouldCallMockserverUsingMutualTlsProtocol() throws Exception {
8888
}
8989

9090
@Test
91-
public void newVersionStartsWithDefaultWaitStrategy() {
91+
void newVersionStartsWithDefaultWaitStrategy() {
9292
try (MockServerContainer mockServer = new MockServerContainer(MOCKSERVER_IMAGE)) {
9393
mockServer.start();
9494
}

0 commit comments

Comments
 (0)