Skip to content

Commit abe5bed

Browse files
committed
Fix import
1 parent 9d9353f commit abe5bed

File tree

2 files changed

+10
-23
lines changed

2 files changed

+10
-23
lines changed

modules/selenium/src/main/java/org/testcontainers/containers/RecordingFileFactory.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,10 @@
11
package org.testcontainers.containers;
22

3-
import org.junit.runner.Description;
43
import org.testcontainers.containers.VncRecordingContainer.VncRecordingFormat;
54

65
import java.io.File;
76

87
public interface RecordingFileFactory {
9-
@Deprecated
10-
default File recordingFileForTest(File vncRecordingDirectory, Description description, boolean succeeded) {
11-
return recordingFileForTest(
12-
vncRecordingDirectory,
13-
description.getTestClass().getSimpleName() + "-" + description.getMethodName(),
14-
succeeded
15-
);
16-
}
17-
188
default File recordingFileForTest(
199
File vncRecordingDirectory,
2010
String prefix,

modules/selenium/src/test/java/org/testcontainers/containers/DefaultRecordingFileFactoryTest.java

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
package org.testcontainers.containers;
22

33
import lombok.Value;
4-
import org.junit.Test;
5-
import org.junit.runner.Description;
6-
import org.junit.runner.RunWith;
7-
import org.junit.runners.Parameterized;
4+
import org.junit.jupiter.api.Test;
5+
import org.junit.jupiter.api.TestInfo;
6+
import org.junit.jupiter.params.ParameterizedClass;
7+
import org.junit.jupiter.params.provider.MethodSource;
88

99
import java.io.File;
1010
import java.nio.file.Files;
@@ -17,9 +17,10 @@
1717

1818
import static org.assertj.core.api.Assertions.assertThat;
1919

20-
@RunWith(Parameterized.class)
20+
@ParameterizedClass
21+
@MethodSource("data")
2122
@Value
22-
public class DefaultRecordingFileFactoryTest {
23+
class DefaultRecordingFileFactoryTest {
2324

2425
private static final DateTimeFormatter DATETIME_FORMATTER = DateTimeFormatter.ofPattern("YYYYMMdd-HHmmss");
2526

@@ -31,7 +32,6 @@ public class DefaultRecordingFileFactoryTest {
3132

3233
private final boolean success;
3334

34-
@Parameterized.Parameters
3535
public static Collection<Object[]> data() {
3636
Collection<Object[]> args = new ArrayList<>();
3737
args.add(new Object[] { "testMethod1", "FAILED", Boolean.FALSE });
@@ -40,13 +40,10 @@ public static Collection<Object[]> data() {
4040
}
4141

4242
@Test
43-
public void recordingFileThatShouldDescribeTheTestResultAtThePresentTime() throws Exception {
43+
public void recordingFileThatShouldDescribeTheTestResultAtThePresentTime(TestInfo testInfo) throws Exception {
4444
File vncRecordingDirectory = Files.createTempDirectory("recording").toFile();
45-
Description description = Description.createTestDescription(
46-
getClass().getCanonicalName(),
47-
methodName,
48-
Test.class
49-
);
45+
String className = testInfo.getTestClass().orElseThrow(IllegalStateException::new).getSimpleName();
46+
String description = className + "-" + methodName;
5047

5148
File recordingFile = factory.recordingFileForTest(vncRecordingDirectory, description, success);
5249

0 commit comments

Comments
 (0)