Removal of containers from the cache is not synchronized (#4598)

edee111 · Eduard Tomek · web-flow · commit ada816c136d6 · 2022-05-18T11:59:44.000+02:00
Co-authored-by: Eduard Tomek &lt;eduard.tomek@usu.com&gt;
diff --git a/modules/jdbc/src/main/java/org/testcontainers/jdbc/ContainerDatabaseDriver.java b/modules/jdbc/src/main/java/org/testcontainers/jdbc/ContainerDatabaseDriver.java
@@ -162,8 +162,10 @@ private Connection wrapConnection(final Connection connection, final JdbcDatabas
         return new ConnectionWrapper(connection, () -> {
             finalConnections.remove(connection);
             if (!isDaemon && finalConnections.isEmpty()) {
-                container.stop();
-                jdbcUrlContainerCache.remove(connectionUrl.getUrl());
+                synchronized (jdbcUrlContainerCache) {
+                    container.stop();
+                    jdbcUrlContainerCache.remove(connectionUrl.getUrl());
+                }
             }
         });
     }

Original file line number	Diff line number	Diff line change
`@@ -162,8 +162,10 @@ private Connection wrapConnection(final Connection connection, final JdbcDatabas`
`162`	`162`	`return new ConnectionWrapper(connection, () -> {`
`163`	`163`	`finalConnections.remove(connection);`
`164`	`164`	`if (!isDaemon && finalConnections.isEmpty()) {`
`165`		`- container.stop();`
`166`		`- jdbcUrlContainerCache.remove(connectionUrl.getUrl());`
	`165`	`+ synchronized (jdbcUrlContainerCache) {`
	`166`	`+ container.stop();`
	`167`	`+ jdbcUrlContainerCache.remove(connectionUrl.getUrl());`
	`168`	`+ }`
`167`	`169`	`}`
`168`	`170`	`});`
`169`	`171`	`}`