Skip to content

Commit c08d003

Browse files
authored
Do not use network aliases in KAFKA_CONTROLLER_QUORUM_VOTERS (#9144)
Fixes #9143
1 parent e60b1ac commit c08d003

File tree

3 files changed

+3
-13
lines changed

3 files changed

+3
-13
lines changed

modules/kafka/src/main/java/org/testcontainers/containers/KafkaContainer.java

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -331,13 +331,7 @@ void withRaft() {
331331
addEnvVar("KAFKA_LISTENERS", kafkaListeners());
332332
addEnvVar("KAFKA_PROCESS_ROLES", "broker,controller");
333333

334-
String firstNetworkAlias = getNetworkAliases().stream().findFirst().orElse(null);
335-
String networkAlias = getNetwork() != null ? firstNetworkAlias : "localhost";
336-
String controllerQuorumVoters = String.format(
337-
"%s@%s:9094",
338-
getEnvVars().get("KAFKA_NODE_ID"),
339-
networkAlias
340-
);
334+
String controllerQuorumVoters = String.format("%s@localhost:9094", getEnvVars().get("KAFKA_NODE_ID"));
341335
this.envVars.computeIfAbsent("KAFKA_CONTROLLER_QUORUM_VOTERS", key -> controllerQuorumVoters);
342336
addEnvVar("KAFKA_CONTROLLER_LISTENER_NAMES", "CONTROLLER");
343337

modules/kafka/src/main/java/org/testcontainers/kafka/ConfluentKafkaContainer.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,7 @@ public ConfluentKafkaContainer(DockerImageName dockerImageName) {
4545
protected void configure() {
4646
KafkaHelper.resolveListeners(this, this.listeners);
4747

48-
String firstNetworkAlias = getNetworkAliases().stream().findFirst().orElse(null);
49-
String networkAlias = getNetwork() != null ? firstNetworkAlias : "localhost";
50-
String controllerQuorumVoters = String.format("%s@%s:9094", getEnvMap().get("KAFKA_NODE_ID"), networkAlias);
48+
String controllerQuorumVoters = String.format("%s@localhost:9094", getEnvMap().get("KAFKA_NODE_ID"));
5149
withEnv("KAFKA_CONTROLLER_QUORUM_VOTERS", controllerQuorumVoters);
5250
}
5351

modules/kafka/src/main/java/org/testcontainers/kafka/KafkaContainer.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,7 @@ public KafkaContainer(DockerImageName dockerImageName) {
5252
protected void configure() {
5353
KafkaHelper.resolveListeners(this, this.listeners);
5454

55-
String firstNetworkAlias = getNetworkAliases().stream().findFirst().orElse(null);
56-
String networkAlias = getNetwork() != null ? firstNetworkAlias : "localhost";
57-
String controllerQuorumVoters = String.format("%s@%s:9094", getEnvMap().get("KAFKA_NODE_ID"), networkAlias);
55+
String controllerQuorumVoters = String.format("%s@localhost:9094", getEnvMap().get("KAFKA_NODE_ID"));
5856
withEnv("KAFKA_CONTROLLER_QUORUM_VOTERS", controllerQuorumVoters);
5957
}
6058

0 commit comments

Comments
 (0)