Skip to content

Commit c0c02e0

Browse files
authored
Use implicitlyWait(Duration) in selenium examples (#6224)
`implicitlyWait(long, TimeUnit)` is deprecated. Use `implicitlyWait(Duration)` instead.
1 parent b7a72e0 commit c0c02e0

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

examples/selenium-container/src/test/java/SeleniumContainerTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@
1919
import org.testcontainers.containers.BrowserWebDriverContainer.VncRecordingMode;
2020

2121
import java.io.File;
22+
import java.time.Duration;
2223
import java.util.List;
23-
import java.util.concurrent.TimeUnit;
2424

2525
import static org.assertj.core.api.Assertions.assertThat;
2626

@@ -43,7 +43,7 @@ public class SeleniumContainerTest {
4343
@Test
4444
public void simplePlainSeleniumTest() {
4545
RemoteWebDriver driver = new RemoteWebDriver(chrome.getSeleniumAddress(), new ChromeOptions());
46-
driver.manage().timeouts().implicitlyWait(30, TimeUnit.SECONDS);
46+
driver.manage().timeouts().implicitlyWait(Duration.ofSeconds(30));
4747

4848
driver.get("http://host.testcontainers.internal:" + port + "/foo.html");
4949
List<WebElement> hElement = driver.findElements(By.tagName("h"));

modules/selenium/src/test/java/org/testcontainers/junit/BaseWebDriverContainerTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
import org.testcontainers.containers.wait.strategy.HttpWaitStrategy;
1414
import org.testcontainers.utility.DockerImageName;
1515

16-
import java.util.concurrent.TimeUnit;
16+
import java.time.Duration;
1717

1818
import static org.assertj.core.api.Assertions.assertThat;
1919

@@ -36,7 +36,7 @@ public class BaseWebDriverContainerTest {
3636

3737
protected static void doSimpleExplore(BrowserWebDriverContainer<?> rule, Capabilities capabilities) {
3838
RemoteWebDriver driver = new RemoteWebDriver(rule.getSeleniumAddress(), capabilities);
39-
driver.manage().timeouts().implicitlyWait(30, TimeUnit.SECONDS);
39+
driver.manage().timeouts().implicitlyWait(Duration.ofSeconds(30));
4040
System.out.println("Selenium remote URL is: " + rule.getSeleniumAddress());
4141
System.out.println("VNC URL is: " + rule.getVncAddress());
4242

@@ -52,7 +52,7 @@ protected static void doSimpleExplore(BrowserWebDriverContainer<?> rule, Capabil
5252
protected void assertBrowserNameIs(BrowserWebDriverContainer<?> rule, String expectedName) {
5353
Capabilities capabilities = ("chrome".equals(expectedName)) ? new ChromeOptions() : new FirefoxOptions();
5454
RemoteWebDriver driver = new RemoteWebDriver(rule.getSeleniumAddress(), capabilities);
55-
driver.manage().timeouts().implicitlyWait(30, TimeUnit.SECONDS);
55+
driver.manage().timeouts().implicitlyWait(Duration.ofSeconds(30));
5656
String actual = driver.getCapabilities().getBrowserName();
5757
assertThat(actual).as(String.format("actual browser name is %s", actual)).isEqualTo(expectedName);
5858
driver.quit();

0 commit comments

Comments
 (0)