Remove accidental overwrite of user properties (#4311)

pioorg · bsideup · web-flow · commit c6f0eaa12d0b · 2021-08-03T12:00:27.000+01:00
`userProperties` shall be saved only after successful update of config file.

Co-authored-by: Sergei Egorov &lt;bsideup@gmail.com&gt;
diff --git a/core/src/main/java/org/testcontainers/utility/TestcontainersConfiguration.java b/core/src/main/java/org/testcontainers/utility/TestcontainersConfiguration.java
@@ -306,8 +306,6 @@ public boolean updateUserConfig(@NonNull String prop, @NonNull String value) {
                 return false;
             }
 
-            userProperties.setProperty(prop, value);
-
             USER_CONFIG_FILE.createNewFile();
             try (OutputStream outputStream = new FileOutputStream(USER_CONFIG_FILE)) {
                 userProperties.store(outputStream, "Modified by Testcontainers");

Original file line number	Diff line number	Diff line change
`@@ -306,8 +306,6 @@ public boolean updateUserConfig(@NonNull String prop, @NonNull String value) {`
`306`	`306`	`return false;`
`307`	`307`	`}`
`308`	`308`
`309`		`- userProperties.setProperty(prop, value);`
`310`		`-`
`311`	`309`	`USER_CONFIG_FILE.createNewFile();`
`312`	`310`	`try (OutputStream outputStream = new FileOutputStream(USER_CONFIG_FILE)) {`
`313`	`311`	`userProperties.store(outputStream, "Modified by Testcontainers");`