Protect NetworkImpl#close from concurrency issues (#2203)

pivovarit · bsideup · web-flow · commit cbd3220c555e · 2020-04-12T16:02:39.000+02:00
* Increase thread safety of NetworkImpl

* un-volatile `id`

Co-authored-by: Sergei Egorov &lt;bsideup@gmail.com&gt;
diff --git a/core/src/main/java/org/testcontainers/containers/Network.java b/core/src/main/java/org/testcontainers/containers/Network.java
@@ -97,7 +97,7 @@ protected void after() {
         }
 
         @Override
-        public void close() {
+        public synchronized void close() {
             if (initialized.getAndSet(false)) {
                 ResourceReaper.instance().removeNetworkById(id);
             }

Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,7 @@ protected void after() {`
`97`	`97`	`}`
`98`	`98`
`99`	`99`	`@Override`
`100`		`- public void close() {`
	`100`	`+ public synchronized void close() {`
`101`	`101`	`if (initialized.getAndSet(false)) {`
`102`	`102`	`ResourceReaper.instance().removeNetworkById(id);`
`103`	`103`	`}`