Skip to content

Commit cbd9426

Browse files
kiviewAnna Chernyshova
andcommitted
Remove deprecated API usage from docs
Co-authored-by: Anna Chernyshova <[email protected]>
1 parent e6d50d8 commit cbd9426

File tree

6 files changed

+13
-22
lines changed

6 files changed

+13
-22
lines changed

docs/modules/webdriver_containers.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -78,10 +78,6 @@ If you would like to customise the file name of the recording, or provide a diff
7878

7979
Note the factory must implement `org.testcontainers.containers.RecordingFileFactory`.
8080

81-
## More examples
82-
83-
A few different examples are shown in [ChromeWebDriverContainerTest.java](https://github.com/testcontainers/testcontainers-java/blob/master/modules/selenium/src/test/java/org/testcontainers/junit/ChromeWebDriverContainerTest.java).
84-
8581
## Adding this module to your project dependencies
8682

8783
Add the following dependency to your `pom.xml`/`build.gradle` file:

modules/selenium/src/main/java/org/testcontainers/containers/BrowserWebDriverContainer.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,9 @@ public BrowserWebDriverContainer(DockerImageName dockerImageName) {
127127
recordingMode = VncRecordingMode.SKIP;
128128
}
129129

130+
/**
131+
* @deprecated
132+
*/
130133
public SELF withCapabilities(Capabilities capabilities) {
131134
this.capabilities = capabilities;
132135
return self();

modules/selenium/src/test/java/org/testcontainers/junit/ChromeRecordingWebDriverContainerTest.java

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,7 @@ public void recordingTestThatShouldBeRecordedAndRetainedInFlvFormatAsDefault() t
5050
try (
5151
// recordAll {
5252
// To do this, simply add extra parameters to the rule constructor, so video will default to FLV format:
53-
BrowserWebDriverContainer<?> chrome = new BrowserWebDriverContainer<>()
54-
.withCapabilities(new ChromeOptions())
53+
BrowserWebDriverContainer<?> chrome = new BrowserWebDriverContainer<>("selenium/standalone-chrome:4.1.1")
5554
.withRecordingMode(RECORD_ALL, target)
5655
// }
5756
.withRecordingFileFactory(new DefaultRecordingFileFactory())
@@ -88,8 +87,7 @@ public void recordingTestShouldHaveFlvExtension() throws InterruptedException {
8887
try (
8988
// recordFlv {
9089
// Set (explicitly) FLV format for recorded video:
91-
BrowserWebDriverContainer<?> chrome = new BrowserWebDriverContainer<>()
92-
.withCapabilities(new ChromeOptions())
90+
BrowserWebDriverContainer<?> chrome = new BrowserWebDriverContainer<>("selenium/standalone-chrome:4.1.1")
9391
.withRecordingMode(RECORD_ALL, target, VncRecordingFormat.FLV)
9492
// }
9593
.withRecordingFileFactory(new DefaultRecordingFileFactory())
@@ -106,8 +104,7 @@ public void recordingTestShouldHaveMp4Extension() throws InterruptedException {
106104
try (
107105
// recordMp4 {
108106
// Set MP4 format for recorded video:
109-
BrowserWebDriverContainer<?> chrome = new BrowserWebDriverContainer<>()
110-
.withCapabilities(new ChromeOptions())
107+
BrowserWebDriverContainer<?> chrome = new BrowserWebDriverContainer<>("selenium/standalone-chrome:4.1.1")
111108
.withRecordingMode(RECORD_ALL, target, VncRecordingFormat.MP4)
112109
// }
113110
.withRecordingFileFactory(new DefaultRecordingFileFactory())
@@ -122,8 +119,7 @@ public void recordingTestShouldHaveMp4Extension() throws InterruptedException {
122119
public void recordingTestThatShouldHaveCorrectDuration() throws IOException, InterruptedException {
123120
MountableFile mountableFile;
124121
try (
125-
BrowserWebDriverContainer<?> chrome = new BrowserWebDriverContainer<>()
126-
.withCapabilities(new ChromeOptions())
122+
BrowserWebDriverContainer<?> chrome = new BrowserWebDriverContainer<>("selenium/standalone-chrome:4.1.1")
127123
.withRecordingMode(RECORD_ALL, vncRecordingDirectory.getRoot())
128124
.withRecordingFileFactory(new DefaultRecordingFileFactory())
129125
.withNetwork(NETWORK)
@@ -158,9 +154,8 @@ public static class ChromeThatRecordsFailingTests {
158154
public void recordingTestThatShouldBeRecordedButNotPersisted() {
159155
try (
160156
// withRecordingFileFactory {
161-
BrowserWebDriverContainer<?> chrome = new BrowserWebDriverContainer<>()
157+
BrowserWebDriverContainer<?> chrome = new BrowserWebDriverContainer<>("selenium/standalone-chrome:4.1.1")
162158
// }
163-
.withCapabilities(new ChromeOptions())
164159
// withRecordingFileFactory {
165160
.withRecordingFileFactory(new CustomRecordingFileFactory())
166161
// }
@@ -178,8 +173,7 @@ public void recordingTestThatShouldBeRecordedAndRetained() throws InterruptedExc
178173
try (
179174
// recordFailing {
180175
// or if you only want videos for test failures:
181-
BrowserWebDriverContainer<?> chrome = new BrowserWebDriverContainer<>()
182-
.withCapabilities(new ChromeOptions())
176+
BrowserWebDriverContainer<?> chrome = new BrowserWebDriverContainer<>("selenium/standalone-chrome:4.1.1")
183177
.withRecordingMode(RECORD_FAILING, target)
184178
// }
185179
.withRecordingFileFactory(new DefaultRecordingFileFactory())

modules/selenium/src/test/java/org/testcontainers/junit/ChromeWebDriverContainerTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,7 @@ public class ChromeWebDriverContainerTest extends BaseWebDriverContainerTest {
1313

1414
// junitRule {
1515
@Rule
16-
public BrowserWebDriverContainer<?> chrome = new BrowserWebDriverContainer<>()
17-
.withCapabilities(new ChromeOptions())
16+
public BrowserWebDriverContainer<?> chrome = new BrowserWebDriverContainer<>("selenium/standalone-chrome:4.1.1")
1817
// }
1918
.withNetwork(NETWORK);
2019

modules/selenium/src/test/java/org/testcontainers/junit/FirefoxWebDriverContainerTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,7 @@ public class FirefoxWebDriverContainerTest extends BaseWebDriverContainerTest {
1313

1414
// junitRule {
1515
@Rule
16-
public BrowserWebDriverContainer<?> firefox = new BrowserWebDriverContainer<>()
17-
.withCapabilities(new FirefoxOptions())
16+
public BrowserWebDriverContainer<?> firefox = new BrowserWebDriverContainer<>("selenium/standalone-firefox:4.1.1")
1817
// }
1918
.withNetwork(NETWORK);
2019

modules/selenium/src/test/java/org/testcontainers/junit/LocalServerWebDriverContainerTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
public class LocalServerWebDriverContainerTest {
2121

2222
@Rule
23-
public BrowserWebDriverContainer chrome = new BrowserWebDriverContainer().withCapabilities(new ChromeOptions());
23+
public BrowserWebDriverContainer<?> chrome = new BrowserWebDriverContainer<>("selenium/standalone-chrome:4.1.1");
2424
private int localPort;
2525

2626
/**
@@ -50,7 +50,7 @@ public void setupLocalServer() throws Exception {
5050
@Test
5151
public void testConnection() {
5252
// getWebDriver {
53-
RemoteWebDriver driver = chrome.getWebDriver();
53+
RemoteWebDriver driver = new RemoteWebDriver(chrome.getSeleniumAddress(), new ChromeOptions());
5454
// }
5555

5656
// Construct a URL that the browser container can access

0 commit comments

Comments
 (0)