Skip to content

Commit ccfdbc3

Browse files
committed
Modify test to perform a query execution
1 parent 1bc4c20 commit ccfdbc3

File tree

4 files changed

+78
-58
lines changed

4 files changed

+78
-58
lines changed

modules/mariadb/src/test/java/org/testcontainers/containers/MariaDBR2DBCDatabaseContainerTest.java

Lines changed: 20 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package org.testcontainers.containers;
22

3+
import io.r2dbc.spi.ConnectionFactories;
4+
import io.r2dbc.spi.ConnectionFactory;
35
import io.r2dbc.spi.ConnectionFactoryOptions;
46
import org.junit.Test;
57
import org.testcontainers.r2dbc.AbstractR2DBCDatabaseContainerTest;
@@ -26,20 +28,23 @@ protected MariaDBContainer<?> createContainer() {
2628

2729
@Test
2830
public void testGetR2DBCUrl() {
29-
MariaDBContainer<?> container = createContainer();
30-
container.start();
31-
32-
String expectedUrl =
33-
"r2dbc:mariadb://" +
34-
container.getHost() +
35-
":" +
36-
container.getMappedPort(MariaDBContainer.MARIADB_PORT) +
37-
"/" +
38-
container.getDatabaseName() +
39-
container.constructUrlParameters("?", "&");
40-
41-
String r2dbcUrl = MariaDBR2DBCDatabaseContainer.getR2dbcUrl(container);
42-
assertThat(expectedUrl).isEqualTo(r2dbcUrl);
43-
container.stop();
31+
try (MariaDBContainer<?> container = createContainer()) {
32+
container.start();
33+
34+
String expectedUrl =
35+
"r2dbc:mariadb://" +
36+
container.getHost() +
37+
":" +
38+
container.getMappedPort(MariaDBContainer.MARIADB_PORT) +
39+
"/" +
40+
container.getDatabaseName() +
41+
container.constructUrlParameters("?", "&");
42+
43+
ConnectionFactory connectionFactory = ConnectionFactories.get(getOptions(container));
44+
runTestQuery(connectionFactory);
45+
46+
String r2dbcUrl = MariaDBR2DBCDatabaseContainer.getR2dbcUrl(container);
47+
assertThat(expectedUrl).isEqualTo(r2dbcUrl);
48+
}
4449
}
4550
}

modules/mssqlserver/src/test/java/org/testcontainers/containers/MSSQLR2DBCDatabaseContainerTest.java

Lines changed: 18 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package org.testcontainers.containers;
22

3+
import io.r2dbc.spi.ConnectionFactories;
4+
import io.r2dbc.spi.ConnectionFactory;
35
import io.r2dbc.spi.ConnectionFactoryOptions;
46
import org.junit.Test;
57
import org.testcontainers.MSSQLServerTestImages;
@@ -26,18 +28,21 @@ protected MSSQLServerContainer<?> createContainer() {
2628

2729
@Test
2830
public void testGetR2DBCUrl() {
29-
MSSQLServerContainer<?> container = createContainer();
30-
container.start();
31-
32-
String expectedUrl =
33-
"r2dbc:sqlserver://" +
34-
container.getHost() +
35-
":" +
36-
container.getMappedPort(MSSQLServerContainer.MS_SQL_SERVER_PORT) +
37-
container.constructUrlParameters(";", ";");
38-
39-
String r2dbcUrl = MSSQLR2DBCDatabaseContainer.getR2dbcUrl(container);
40-
assertThat(expectedUrl).isEqualTo(r2dbcUrl);
41-
container.stop();
31+
try (MSSQLServerContainer<?> container = createContainer()) {
32+
container.start();
33+
34+
String expectedUrl =
35+
"r2dbc:sqlserver://" +
36+
container.getHost() +
37+
":" +
38+
container.getMappedPort(MSSQLServerContainer.MS_SQL_SERVER_PORT) +
39+
container.constructUrlParameters(";", ";");
40+
41+
ConnectionFactory connectionFactory = ConnectionFactories.get(getOptions(container));
42+
runTestQuery(connectionFactory);
43+
44+
String r2dbcUrl = MSSQLR2DBCDatabaseContainer.getR2dbcUrl(container);
45+
assertThat(expectedUrl).isEqualTo(r2dbcUrl);
46+
}
4247
}
4348
}

modules/mysql/src/test/java/org/testcontainers/containers/MySQLR2DBCDatabaseContainerTest.java

Lines changed: 20 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package org.testcontainers.containers;
22

3+
import io.r2dbc.spi.ConnectionFactories;
4+
import io.r2dbc.spi.ConnectionFactory;
35
import io.r2dbc.spi.ConnectionFactoryOptions;
46
import org.junit.Test;
57
import org.testcontainers.MySQLTestImages;
@@ -26,20 +28,23 @@ protected MySQLContainer<?> createContainer() {
2628

2729
@Test
2830
public void testGetR2DBCUrl() {
29-
MySQLContainer<?> container = createContainer();
30-
container.start();
31-
32-
String expectedUrl =
33-
"r2dbc:mysql://" +
34-
container.getHost() +
35-
":" +
36-
container.getMappedPort(MySQLContainer.MYSQL_PORT) +
37-
"/" +
38-
container.getDatabaseName() +
39-
container.constructUrlParameters("?", "&");
40-
41-
String r2dbcUrl = MySQLR2DBCDatabaseContainer.getR2dbcUrl(container);
42-
assertThat(expectedUrl).isEqualTo(r2dbcUrl);
43-
container.stop();
31+
try (MySQLContainer<?> container = createContainer()) {
32+
container.start();
33+
34+
String expectedUrl =
35+
"r2dbc:mysql://" +
36+
container.getHost() +
37+
":" +
38+
container.getMappedPort(MySQLContainer.MYSQL_PORT) +
39+
"/" +
40+
container.getDatabaseName() +
41+
container.constructUrlParameters("?", "&");
42+
43+
ConnectionFactory connectionFactory = ConnectionFactories.get(getOptions(container));
44+
runTestQuery(connectionFactory);
45+
46+
String r2dbcUrl = MySQLR2DBCDatabaseContainer.getR2dbcUrl(container);
47+
assertThat(expectedUrl).isEqualTo(r2dbcUrl);
48+
}
4449
}
4550
}

modules/postgresql/src/test/java/org/testcontainers/containers/PostgreSQLR2DBCDatabaseContainerTest.java

Lines changed: 20 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package org.testcontainers.containers;
22

3+
import io.r2dbc.spi.ConnectionFactories;
4+
import io.r2dbc.spi.ConnectionFactory;
35
import io.r2dbc.spi.ConnectionFactoryOptions;
46
import org.junit.Test;
57
import org.testcontainers.PostgreSQLTestImages;
@@ -33,20 +35,23 @@ protected String createR2DBCUrl() {
3335

3436
@Test
3537
public void testGetR2DBCUrl() {
36-
PostgreSQLContainer<?> container = createContainer();
37-
container.start();
38-
39-
String expectedUrl =
40-
"r2dbc:postgresql://" +
41-
container.getHost() +
42-
":" +
43-
container.getMappedPort(PostgreSQLContainer.POSTGRESQL_PORT) +
44-
"/" +
45-
container.getDatabaseName() +
46-
container.constructUrlParameters("?", "&");
47-
48-
String r2dbcUrl = PostgreSQLR2DBCDatabaseContainer.getR2dbcUrl(container);
49-
assertThat(expectedUrl).isEqualTo(r2dbcUrl);
50-
container.stop();
38+
try (PostgreSQLContainer<?> container = createContainer()) {
39+
container.start();
40+
41+
String expectedUrl =
42+
"r2dbc:postgresql://" +
43+
container.getHost() +
44+
":" +
45+
container.getMappedPort(PostgreSQLContainer.POSTGRESQL_PORT) +
46+
"/" +
47+
container.getDatabaseName() +
48+
container.constructUrlParameters("?", "&");
49+
50+
ConnectionFactory connectionFactory = ConnectionFactories.get(getOptions(container));
51+
runTestQuery(connectionFactory);
52+
53+
String r2dbcUrl = PostgreSQLR2DBCDatabaseContainer.getR2dbcUrl(container);
54+
assertThat(expectedUrl).isEqualTo(r2dbcUrl);
55+
}
5156
}
5257
}

0 commit comments

Comments
 (0)