Skip to content

Commit e4c533a

Browse files
committed
Polish oracle-free
1 parent a52eadb commit e4c533a

File tree

2 files changed

+9
-10
lines changed

2 files changed

+9
-10
lines changed

modules/oracle-free/src/main/java/org/testcontainers/oracle/OracleContainer.java

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,10 @@
33
import org.apache.commons.lang3.StringUtils;
44
import org.jetbrains.annotations.NotNull;
55
import org.testcontainers.containers.JdbcDatabaseContainer;
6-
import org.testcontainers.containers.wait.strategy.LogMessageWaitStrategy;
6+
import org.testcontainers.containers.wait.strategy.Wait;
77
import org.testcontainers.utility.DockerImageName;
88

99
import java.time.Duration;
10-
import java.time.temporal.ChronoUnit;
1110
import java.util.Arrays;
1211
import java.util.Collections;
1312
import java.util.List;
@@ -68,11 +67,11 @@ public OracleContainer(String dockerImageName) {
6867
public OracleContainer(final DockerImageName dockerImageName) {
6968
super(dockerImageName);
7069
dockerImageName.assertCompatibleWith(DEFAULT_IMAGE_NAME);
71-
this.waitStrategy =
72-
new LogMessageWaitStrategy()
73-
.withRegEx(".*DATABASE IS READY TO USE!.*\\s")
74-
.withTimes(1)
75-
.withStartupTimeout(Duration.of(DEFAULT_STARTUP_TIMEOUT_SECONDS, ChronoUnit.SECONDS));
70+
waitingFor(
71+
Wait
72+
.forLogMessage(".*DATABASE IS READY TO USE!.*\\s", 1)
73+
.withStartupTimeout(Duration.ofSeconds(DEFAULT_STARTUP_TIMEOUT_SECONDS))
74+
);
7675
withConnectTimeoutSeconds(DEFAULT_CONNECT_TIMEOUT_SECONDS);
7776
addExposedPorts(ORACLE_PORT);
7877
}

modules/oracle-free/src/test/java/org/testcontainers/junit/oracle/SimpleOracleTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ private void runTest(OracleContainer container, String databaseName, String user
3333

3434
@Test
3535
public void testDefaultSettings() throws SQLException {
36-
try (OracleContainer oracle = new OracleContainer(ORACLE_DOCKER_IMAGE_NAME);) {
36+
try (OracleContainer oracle = new OracleContainer(ORACLE_DOCKER_IMAGE_NAME)) {
3737
runTest(oracle, "freepdb1", "test", "test");
3838

3939
// Match against the last '/'
@@ -76,7 +76,7 @@ public void testCustomUser() throws SQLException {
7676

7777
@Test
7878
public void testSID() throws SQLException {
79-
try (OracleContainer oracle = new OracleContainer(ORACLE_DOCKER_IMAGE_NAME).usingSid();) {
79+
try (OracleContainer oracle = new OracleContainer(ORACLE_DOCKER_IMAGE_NAME).usingSid()) {
8080
runTest(oracle, "freepdb1", "system", "test");
8181

8282
// Match against the last ':'
@@ -90,7 +90,7 @@ public void testSIDAndCustomPassword() throws SQLException {
9090
try (
9191
OracleContainer oracle = new OracleContainer(ORACLE_DOCKER_IMAGE_NAME)
9292
.usingSid()
93-
.withPassword("testPassword");
93+
.withPassword("testPassword")
9494
) {
9595
runTest(oracle, "freepdb1", "system", "testPassword");
9696
}

0 commit comments

Comments
 (0)