Skip to content

Commit e6e3331

Browse files
neetkeekiview
authored andcommitted
Correct sqlserver jdbc url should be supported by jdbc driver proxy (#989)
1 parent 40cdd58 commit e6e3331

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

modules/jdbc-test/src/test/java/org/testcontainers/jdbc/JDBCDriverTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ public static Iterable<Object[]> data() {
6464
{"jdbc:tc:mariadb:10.2.14://hostname/databasename?user=someuser&password=somepwd&TC_INITFUNCTION=org.testcontainers.jdbc.JDBCDriverTest::sampleInitFunction", EnumSet.of(Options.ScriptedSchema, Options.JDBCParams)},
6565
{"jdbc:tc:mariadb:10.2.14://hostname/databasename?TC_MY_CNF=somepath/mariadb_conf_override", EnumSet.of(Options.CustomIniFile)},
6666
{"jdbc:tc:clickhouse://hostname/databasename", EnumSet.of(Options.PmdKnownBroken)},
67+
{"jdbc:tc:sqlserver:2017-CU12://hostname:hostport;databaseName=databasename", EnumSet.noneOf(Options.class)},
6768
});
6869
}
6970

modules/mssqlserver/src/main/java/org/testcontainers/containers/MSSQLServerContainer.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@
66
* @author Stefan Hufschmidt
77
*/
88
public class MSSQLServerContainer<SELF extends MSSQLServerContainer<SELF>> extends JdbcDatabaseContainer<SELF> {
9-
public static final String NAME = "mssqlserver";
9+
10+
public static final String NAME = "sqlserver";
1011
public static final String IMAGE = "mcr.microsoft.com/mssql/server";
1112
public static final String DEFAULT_TAG = "2017-CU12";
1213

0 commit comments

Comments
 (0)