Delegate copyFile{To,From}Container's state verification to Docker (#3805)

This commit closes #3264 by letting the Docker daemon decide in which state
the copy operation could be performed (we were too strict about it before).
Now, only a quick check (`containerId != null`) is performed.

Co-authored-by: Andrew Jefferson <[email protected]>
Co-authored-by: Sergei Egorov <[email protected]>

Author: 3 people

core/src/main/java/org/testcontainers/containers/ContainerState.java

@@ -260,7 +260,7 @@ default void copyFileToContainer(MountableFile mountableFile, String containerPa
      */
     @SneakyThrows(IOException.class)
     default void copyFileToContainer(Transferable transferable, String containerPath) {
-        if (!isCreated()) {
+        if (getContainerId() == null) {
             throw new IllegalStateException("copyFileToContainer can only be used with created / running container");
         }
 
@@ -306,7 +306,7 @@ default void copyFileFromContainer(String containerPath, String destinationPath)
      */
     @SneakyThrows
     default  <T> T copyFileFromContainer(String containerPath, ThrowingFunction<InputStream, T> function) {
-        if (!isCreated()) {
+        if (getContainerId() == null) {
             throw new IllegalStateException("copyFileFromContainer can only be used when the Container is created.");
         }
 

core/src/test/java/org/testcontainers/junit/FileOperationsTest.java

@@ -2,15 +2,19 @@
 
 import com.github.dockerjava.api.exception.NotFoundException;
 import org.apache.commons.io.FileUtils;
+import org.apache.commons.io.IOUtils;
+import org.assertj.core.api.Assertions;
 import org.junit.Rule;
 import org.junit.Test;
 import org.junit.rules.TemporaryFolder;
 import org.testcontainers.containers.GenericContainer;
+import org.testcontainers.containers.startupcheck.OneShotStartupCheckStrategy;
 import org.testcontainers.utility.MountableFile;
 
 import java.io.File;
 import java.io.IOException;
 
+import static org.assertj.core.api.Assertions.assertThat;
 import static org.rnorth.visibleassertions.VisibleAssertions.assertTrue;
 import static org.testcontainers.TestImages.ALPINE_IMAGE;
 
@@ -103,4 +107,50 @@ public void shouldCopyFileFromContainerTest() throws IOException {
             assertTrue("Files aren't same ", FileUtils.contentEquals(expectedFile, actualFile));
         }
     }
+
+    @Test
+    public void copyFileOperationsShouldFailWhenNotStartedTest() {
+        try (GenericContainer<?> container = new GenericContainer<>(ALPINE_IMAGE).withCommand("top")) {
+            Assertions
+                .assertThatThrownBy(() -> {
+                    MountableFile mountableFile = MountableFile.forClasspathResource("test_copy_to_container.txt");
+                    container.copyFileToContainer(mountableFile, "/home/test.txt");
+                })
+                .isInstanceOf(IllegalStateException.class)
+                .hasMessageContaining("can only be used with created / running container");
+
+            Assertions
+                .assertThatThrownBy(() -> {
+                    container.copyFileFromContainer(
+                        "/home/test_copy_to_container.txt",
+                        IOUtils::toByteArray
+                    );
+                })
+                .isInstanceOf(IllegalStateException.class)
+                .hasMessageContaining("can only be used when the Container is created");
+        }
+    }
+
+    @Test
+    public void shouldCopyFileFromExitedContainerTest() throws IOException {
+        try (
+            GenericContainer<?> container = new GenericContainer<>(ALPINE_IMAGE)
+                .withCommand("sh", "-c", "echo -n 'Hello!' > /home/file_in_container.txt")
+                .withStartupCheckStrategy(new OneShotStartupCheckStrategy())
+        ) {
+            container.start();
+            assertThat(container.getDockerClient().waitContainerCmd(container.getContainerId()).start().awaitStatusCode())
+                .isEqualTo(0);
+
+            container.copyFileFromContainer(
+                "/home/file_in_container.txt",
+                IOUtils::toByteArray
+            );
+
+            container.copyFileToContainer(
+                MountableFile.forClasspathResource("test_copy_to_container.txt"),
+                "/test.txt"
+            );
+        }
+    }
 }