Skip to content

Commit f00cc40

Browse files
committed
fix tests
1 parent 869e9f7 commit f00cc40

File tree

6 files changed

+30
-12
lines changed

6 files changed

+30
-12
lines changed

modules/scylladb/build.gradle

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,16 @@
11
description = "Testcontainers :: ScyllaDB"
22

3+
configurations.all {
4+
resolutionStrategy {
5+
force 'io.dropwizard.metrics:metrics-core:3.2.6'
6+
}
7+
}
8+
39
dependencies {
410
api project(":database-commons")
511
api "com.scylladb:java-driver-core:4.15.0.0"
612
api "com.datastax.cassandra:cassandra-driver-core:3.10.0"
713

8-
testImplementation 'com.scylladb:java-driver-core:4.15.0.0'
9-
testImplementation 'com.datastax.oss:java-driver-core:4.17.0'
14+
// testImplementation 'com.datastax.oss:java-driver-core:4.17.0'
1015
testImplementation 'org.assertj:assertj-core:3.24.2'
1116
}

modules/scylladb/src/main/java/org/testcontainers/containers/ScyllaDBContainer.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,13 @@
2626
*/
2727
public class ScyllaDBContainer<SELF extends ScyllaDBContainer<SELF>> extends GenericContainer<SELF> {
2828

29-
private static final DockerImageName DEFAULT_IMAGE_NAME = DockerImageName.parse("scylladb:scylladb");
29+
private static final DockerImageName DEFAULT_IMAGE_NAME = DockerImageName.parse("scylladb/scylla:5.2.9");
3030

3131
public static final Integer CQL_PORT = 9042;
3232

3333
private static final String DEFAULT_LOCAL_DATACENTER = "datacenter1";
3434

35-
private static final String CONTAINER_CONFIG_LOCATION = "/etc/scylladb";
35+
private static final String CONTAINER_CONFIG_LOCATION = "/etc/scylla";
3636

3737
private static final String USERNAME = "scylladb";
3838

modules/scylladb/src/test/java/org/testcontainers/containers/ScyllaDBContainerTest.java

Lines changed: 18 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,15 @@
66
import com.datastax.driver.core.Session;
77
import lombok.extern.slf4j.Slf4j;
88
import org.junit.Test;
9+
import org.testcontainers.containers.wait.ScyllaDBQueryWaitStrategy;
910
import org.testcontainers.utility.DockerImageName;
1011

1112
import static org.assertj.core.api.Assertions.assertThat;
1213

1314
@Slf4j
1415
public class ScyllaDBContainerTest {
1516

16-
private static final DockerImageName SCYLLADB_IMAGE = DockerImageName.parse("scylladb:5.2.9");
17+
private static final DockerImageName SCYLLADB_IMAGE = DockerImageName.parse("scylladb/scylla:5.2.9");
1718

1819
private static final String TEST_CLUSTER_NAME_IN_CONF = "Test Cluster Integration Test";
1920

@@ -31,22 +32,22 @@ public void testSimple() {
3132

3233
@Test
3334
public void testSpecificVersion() {
34-
String scyllaDBVersion = "5.2.9";
35+
String scyllaDBReportedVersion = "3.0.8";
3536
try (
36-
ScyllaDBContainer<?> ScyllaDBContainer = new ScyllaDBContainer<>(SCYLLADB_IMAGE.withTag(scyllaDBVersion))
37+
ScyllaDBContainer<?> ScyllaDBContainer = new ScyllaDBContainer<>(SCYLLADB_IMAGE)
3738
) {
3839
ScyllaDBContainer.start();
3940
ResultSet resultSet = performQuery(ScyllaDBContainer, BASIC_QUERY);
4041
assertThat(resultSet.wasApplied()).as("Query was applied").isTrue();
41-
assertThat(resultSet.one().getString(0)).as("ScyllaDB has right version").isEqualTo(scyllaDBVersion);
42+
assertThat(resultSet.one().getString(0)).as("ScyllaDB has right version").isEqualTo(scyllaDBReportedVersion);
4243
}
4344
}
4445

4546
@Test
4647
public void testConfigurationOverride() {
4748
try (
4849
ScyllaDBContainer<?> ScyllaDBContainer = new ScyllaDBContainer<>(SCYLLADB_IMAGE)
49-
.withConfigurationOverride("scylladb-test-configuration-example")
50+
.withConfigurationOverride("scylla-test-configuration-example")
5051
) {
5152
ScyllaDBContainer.start();
5253
ResultSet resultSet = performQuery(ScyllaDBContainer, "SELECT cluster_name FROM system.local");
@@ -78,6 +79,18 @@ public void testInitScript() {
7879
}
7980
}
8081

82+
@Test
83+
public void testScyllaDBQueryWaitStrategy() {
84+
try (
85+
ScyllaDBContainer<?> scyllaDBContainer = new ScyllaDBContainer<>(SCYLLADB_IMAGE)
86+
.waitingFor(new ScyllaDBQueryWaitStrategy())
87+
) {
88+
scyllaDBContainer.start();
89+
ResultSet resultSet = performQuery(scyllaDBContainer, BASIC_QUERY);
90+
assertThat(resultSet.wasApplied()).as("Query was applied").isTrue();
91+
}
92+
}
93+
8194
private void testInitScript(ScyllaDBContainer<?> ScyllaDBContainer) {
8295
ResultSet resultSet = performQuery(ScyllaDBContainer, "SELECT * FROM keySpaceTest.catalog_category");
8396
assertThat(resultSet.wasApplied()).as("Query was applied").isTrue();

modules/scylladb/src/test/java/org/testcontainers/containers/ScyllaDBDriver4Test.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
public class ScyllaDBDriver4Test {
1212

1313
@Rule
14-
public ScyllaDBContainer<?> scyllaDB = new ScyllaDBContainer<>("scylladb:5.2.9");
14+
public ScyllaDBContainer<?> scyllaDB = new ScyllaDBContainer<>("scylladb/scylla:5.2.9");
1515

1616
@Test
1717
public void testCassandraGetContactPoint() {

modules/scylladb/src/test/java/org/testcontainers/containers/ScyllaDBServer5Test.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,10 @@
1111
public class ScyllaDBServer5Test {
1212

1313
@Rule
14-
public ScyllaDBContainer<?> scylladb = new ScyllaDBContainer<>("sylladb:5.2.9");
14+
public ScyllaDBContainer<?> scylladb = new ScyllaDBContainer<>("scylladb/scylla:5.2.9");
1515

1616
@Test
17-
public void testCassandraGetContactPoint() {
17+
public void testScyllaDBGetContactPoint() {
1818
try (
1919
CqlSession session = CqlSession
2020
.builder()

modules/scylladb/src/test/resources/scylladb-test-configuration-example/scylladb.yaml renamed to modules/scylladb/src/test/resources/scylla-test-configuration-example/scylla.yaml

File renamed without changes.

0 commit comments

Comments
 (0)