Skip to content

Commit f5e79b9

Browse files
Remove unnecessary configuration from simple tests (#5973)
* Remove mysql configuration from simple test * mysql custom ini file test also runs on Windows Co-authored-by: Kevin Wittek <[email protected]>
1 parent b1fa4ec commit f5e79b9

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

modules/mysql/src/test/java/org/testcontainers/junit/mysql/SimpleMySQLTest.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package org.testcontainers.junit.mysql;
22

3-
import org.apache.commons.lang3.SystemUtils;
43
import org.junit.Test;
54
import org.slf4j.Logger;
65
import org.slf4j.LoggerFactory;
@@ -21,7 +20,6 @@
2120

2221
import static org.assertj.core.api.Assertions.assertThat;
2322
import static org.assertj.core.api.Assertions.fail;
24-
import static org.junit.Assume.assumeFalse;
2523

2624
public class SimpleMySQLTest extends AbstractContainerDatabaseTest {
2725

@@ -48,7 +46,6 @@ public class SimpleMySQLTest extends AbstractContainerDatabaseTest {
4846
public void testSimple() throws SQLException {
4947
try (
5048
MySQLContainer<?> mysql = new MySQLContainer<>(MySQLTestImages.MYSQL_57_IMAGE)
51-
.withConfigurationOverride("somepath/mysql_conf_override")
5249
.withLogConsumer(new Slf4jLogConsumer(logger))
5350
) {
5451
mysql.start();
@@ -81,8 +78,6 @@ public void testSpecificVersion() throws SQLException {
8178

8279
@Test
8380
public void testMySQLWithCustomIniFile() throws SQLException {
84-
assumeFalse(SystemUtils.IS_OS_WINDOWS);
85-
8681
try (
8782
MySQLContainer<?> mysqlCustomConfig = new MySQLContainer<>(MySQLTestImages.MYSQL_56_IMAGE)
8883
.withConfigurationOverride("somepath/mysql_conf_override")

0 commit comments

Comments
 (0)