Make PortforwardingContainer be reusable #6440
                  
                    
                      TomDeBacker
                    
                  
                
                  started this conversation in
                Ideas
              
            Replies: 0 comments
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
        
    
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
This relates to #6410.
Would it make sense to have
PortforwardingContainermake use of thereusefunctionality? Since it extendsGenericContainerit is possible out-of-the-box. As-is a singleton-like pattern is used so that only onesshdcontainer instance is created and updated when needed.It would allow the
PortforwardingContainerto be reused and still offer the same features as-is (from initial observations). The startup time ofPortforwardingContaineris negligible but it might provide a case to make everything more uniform (no more calling static methods onTestcontainers.exposeHost().Is there a specific philosophy behind the current implementation? My proposal could be implemented like:
There might implications I have not thought about, please share your considerations or thoughts. I have proof-of-concept I'm willing to share if there is some traction towards this. Is this something testcontainers-java would benefit from?
Beta Was this translation helpful? Give feedback.
All reactions