Can LocalStackContainer accept a ImageFromDockerfile in constructor?

[marco-luzzara]

I am not sure whether this is a bug or not, but I am trying to temporarily build an image with new ImageFromDockerfile() and pass it to the constructor of LocalStackContainer. Unfortunately, this is not possible because the only allowed constructor accepts a DockerImageName instance. Instead, the GenericContainer allows you to write something like:

new GenericContainer(
    new ImageFromDockerfile().withDockerfile(Path.of(dockerFilePath))
)

Initially, I thought that I could just create the DockerImageName using DockerImageName.parse(), like this:

new LocalStackContainer(
    DockerImageName.parse(new ImageFromDockerfile()
        .withDockerfile(Path.of(dockerFilePath)).getDockerImageName()
    ).asCompatibleSubstituteFor("localstack/localstack")
).withServices(LocalStackContainer.Service.LAMBDA);

But the test fails by timeout and logs repeatedly show

14:52:43.450 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.wire - http-outgoing-1 >> "POST /v1.32/images/create?fromImage=localhost%2Ftestcontainers%2Fxdcgtmnns2nfdmus&tag=latest HTTP/1.1[\r][\n]"
14:52:43.450 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.wire - http-outgoing-1 >> "accept: application/octet-stream[\r][\n]"
14:52:43.450 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.wire - http-outgoing-1 >> "content-type: application/json[\r][\n]"
14:52:43.450 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.wire - http-outgoing-1 >> "x-tc-sid: 0b356b2f-b568-4b4e-b2bb-6de7b1d37342[\r][\n]"
14:52:43.450 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.wire - http-outgoing-1 >> "Accept-Encoding: gzip, x-gzip, deflate[\r][\n]"
14:52:43.450 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.wire - http-outgoing-1 >> "Host: localhost:2375[\r][\n]"
14:52:43.450 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.wire - http-outgoing-1 >> "Connection: keep-alive[\r][\n]"
14:52:43.450 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.wire - http-outgoing-1 >> "User-Agent: Apache-HttpClient/5.0.3 (Java/17)[\r][\n]"
14:52:43.450 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.wire - http-outgoing-1 >> "[\r][\n]"
14:52:43.468 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.wire - http-outgoing-1 << "HTTP/1.1 500 Internal Server Error[\r][\n]"
14:52:43.468 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.wire - http-outgoing-1 << "Api-Version: 1.41[\r][\n]"
14:52:43.468 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.wire - http-outgoing-1 << "Content-Type: application/json[\r][\n]"
14:52:43.468 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.wire - http-outgoing-1 << "Date: Fri, 05 May 2023 12:52:43 GMT[\r][\n]"
14:52:43.468 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.wire - http-outgoing-1 << "Docker-Experimental: false[\r][\n]"
14:52:43.468 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.wire - http-outgoing-1 << "Ostype: linux[\r][\n]"
14:52:43.468 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.wire - http-outgoing-1 << "Server: Docker/20.10.23 (linux)[\r][\n]"
14:52:43.468 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.wire - http-outgoing-1 << "Transfer-Encoding: chunked[\r][\n]"
14:52:43.468 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.wire - http-outgoing-1 << "[\r][\n]"
14:52:43.468 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.headers - http-outgoing-1 << HTTP/1.1 500 Internal Server Error
14:52:43.468 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.headers - http-outgoing-1 << Api-Version: 1.41
14:52:43.468 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.headers - http-outgoing-1 << Content-Type: application/json
14:52:43.468 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.headers - http-outgoing-1 << Date: Fri, 05 May 2023 12:52:43 GMT
14:52:43.468 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.headers - http-outgoing-1 << Docker-Experimental: false
14:52:43.468 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.headers - http-outgoing-1 << Ostype: linux
14:52:43.468 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.headers - http-outgoing-1 << Server: Docker/20.10.23 (linux)
14:52:43.468 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.headers - http-outgoing-1 << Transfer-Encoding: chunked
14:52:43.468 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.impl.classic.MainClientExec - ex-000000D5: connection can be kept alive for 3 MINUTES
14:52:43.468 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.wire - http-outgoing-1 << "5b[\r][\n]"
14:52:43.469 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.wire - http-outgoing-1 << "{"message":"Get \"http://localhost/v2/\": dial tcp [::1]:80: connect: connection refused"}[\n]"
14:52:43.469 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.wire - http-outgoing-1 << "[\r][\n]"
14:52:43.469 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.wire - http-outgoing-1 << "0[\r][\n]"
14:52:43.469 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.wire - http-outgoing-1 << "[\r][\n]"
14:52:43.469 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.impl.classic.InternalHttpClient - ep-000000D4: releasing valid endpoint
14:52:43.469 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.impl.io.PoolingHttpClientConnectionManager - ep-000000D4: releasing endpoint
14:52:43.469 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.impl.io.PoolingHttpClientConnectionManager - ep-000000D4: connection http-outgoing-1 can be kept alive for 3 MINUTES
14:52:43.469 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.impl.io.PoolingHttpClientConnectionManager - ep-000000D4: connection released [route: {}->npipe://localhost:2375][total available: 1; route allocated: 1 of 2147483647; total allocated: 1 of 2147483647]
14:52:43.469 [docker-java-stream-966237793] ERROR com.github.dockerjava.api.async.ResultCallbackTemplate - Error during callback
com.github.dockerjava.api.exception.InternalServerErrorException: Status 500: {"message":"Get \"http://localhost/v2/\": dial tcp [::1]:80: connect: connection refused"}

	at org.testcontainers.shaded.com.github.dockerjava.core.DefaultInvocationBuilder.execute(DefaultInvocationBuilder.java:247)
	at org.testcontainers.shaded.com.github.dockerjava.core.DefaultInvocationBuilder.lambda$executeAndStream$1(DefaultInvocationBuilder.java:269)
	at java.base/java.lang.Thread.run(Thread.java:833)
14:52:43.469 [main] WARN 🐳 [localhost/testcontainers/xdcgtmnns2nfdmus:latest] - Retrying pull for image: localhost/testcontainers/xdcgtmnns2nfdmus:latest (115s remaining)
14:52:43.469 [main] DEBUG org.testcontainers.utility.RegistryAuthLocator - Looking up auth config for image: localhost/testcontainers/xdcgtmnns2nfdmus:latest at registry: localhost
14:52:43.469 [main] DEBUG org.testcontainers.utility.RegistryAuthLocator - No matching Auth Configs - falling back to defaultAuthConfig [null]
14:52:43.469 [main] DEBUG org.testcontainers.dockerclient.AuthDelegatingDockerClientConfig - Effective auth config [null]
14:52:43.470 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.impl.classic.InternalHttpClient - ex-000000D6: preparing request execution
14:52:43.470 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.protocol.RequestAddCookies - Cookie spec selected: strict
14:52:43.470 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.protocol.RequestAuthCache - Auth cache not set in the context
14:52:43.470 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.impl.classic.ProtocolExec - ex-000000D6: target auth state: UNCHALLENGED
14:52:43.470 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.impl.classic.ProtocolExec - ex-000000D6: proxy auth state: UNCHALLENGED
14:52:43.470 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.impl.classic.ConnectExec - ex-000000D6: acquiring connection with route {}->npipe://localhost:2375
14:52:43.470 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.impl.classic.InternalHttpClient - ex-000000D6: acquiring endpoint (3 MINUTES)
14:52:43.470 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.impl.io.PoolingHttpClientConnectionManager - ex-000000D6: endpoint lease request (3 MINUTES) [route: {}->npipe://localhost:2375][total available: 1; route allocated: 1 of 2147483647; total allocated: 1 of 2147483647]
14:52:43.470 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.impl.io.PoolingHttpClientConnectionManager - ex-000000D6: endpoint leased [route: {}->npipe://localhost:2375][total available: 0; route allocated: 1 of 2147483647; total allocated: 1 of 2147483647]
14:52:43.471 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.impl.io.PoolingHttpClientConnectionManager - ex-000000D6: acquired ep-000000D5
14:52:43.471 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.impl.classic.InternalHttpClient - ex-000000D6: acquired endpoint ep-000000D5
14:52:43.471 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.impl.classic.MainClientExec - ex-000000D6: executing POST /v1.32/images/create?fromImage=localhost%2Ftestcontainers%2Fxdcgtmnns2nfdmus&tag=latest HTTP/1.1
14:52:43.471 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.impl.classic.InternalHttpClient - ep-000000D5: start execution ex-000000D6
14:52:43.471 [docker-java-stream-966237793] DEBUG com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.impl.io.PoolingHttpClientConnectionManager - ep-000000D5: executing exchange ex-000000D6 over http-outgoing-1

It is like it cannot find the image because not built yet.
First of all: is that expected? I looked at the source code of LocalStackContainer and introducing a new constructor for this case is definitely possible. Just like GenericContainer has this constructor definition:

public GenericContainer(@NonNull final Future<String> image) {
    setImage(image);
}

public void setImage(Future<String> image) {
    this.image = new RemoteDockerImage(image);
}

Can we add something like this in LocalStackContainer too?

public ExtLocalStackContainer(final Future<String> image) {
    super(image);
    DockerImageName dockerImageName;
    try {
        dockerImageName = DockerImageName.parse(image.get()).asCompatibleSubstituteFor(DEFAULT_IMAGE_NAME);
    } catch (Exception e) {
        throw new RuntimeException(e);
    }
    // ... the rest of constructor initialization
}

Or better, does an alternative exist for creating a localstack-compatible image from a Dockerfile and run it as a @Container?

Environment:
OS: Windows
JDK: 17
TestContainer (and localstack module) version: 1.18.0