Move duplicated code into KCatContainer #10003
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modules/kafka/src/test/java/org/testcontainers/containers/KafkaContainerTest.java
Outdated
Show resolved
Hide resolved
julianladisch
force-pushed
the
KCatContainer
branch
from
27ac9c9 to
88c86cd
Compare
julianladisch
force-pushed
the
KCatContainer
branch
from
88c86cd to
7885de2
Compare
eddumelendez
requested changes
Feb 22, 2025
| .withCopyToContainer(Transferable.of("Message produced by kcat"), "/data/msgs.txt") | ||
| .withNetwork(network) | ||
| .withCommand("-c", "tail -f /dev/null") | ||
| KCatContainer kcat = new KCatContainer().withNetwork(network) |
Member
There was a problem hiding this comment.
I just noticed that this is part of the documentation. So, we should keep it as is.
| .withCopyToContainer(Transferable.of("Message produced by kcat"), "/data/msgs.txt") | ||
| .withNetwork(network) | ||
| .withCommand("-c", "tail -f /dev/null") | ||
| KCatContainer kcat = new KCatContainer().withNetwork(network) |
Contributor
Author
|
Code change has been rejected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.