Update examples/sftp: Dependencies, container, host key #10096
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update all dependencies to latest versions. Update container from single arch atmoz/sftp:alpine-3.7 to multi arch jmcombs/sftp:alpine, see https://github.com/jmcombs/sftp Replace insecure `"StrictHostKeyChecking", "no"` with a sample host key to demonstrate that the test should also cover the host key checking.
julianladisch
force-pushed
the
update-sftp
branch
from
dac0662 to
be40769
Compare
eddumelendez
requested changes
Mar 20, 2025
Member
eddumelendez
left a comment
eddumelendez
left a comment
There was a problem hiding this comment.
Hi, thanks for your contribution! This is a nice example, would you mind taking care of comments?
| MountableFile.forClasspathResource("testcontainers/", 0777), | ||
| "/home/foo/upload/testcontainers" | ||
| ) | ||
| .withCopyFileToContainer( |
Member
There was a problem hiding this comment.
can you create an additional test, please?
Comment on lines
+12
to
+15
| testImplementation 'org.assertj:assertj-core:3.27.3' | ||
| testImplementation 'ch.qos.logback:logback-classic:1.5.17' | ||
| testImplementation 'org.junit.jupiter:junit-jupiter:5.12.1' | ||
| testRuntimeOnly 'org.junit.platform:junit-platform-launcher' |
Member
There was a problem hiding this comment.
do not update dependencies
Contributor
Author
|
Closing as requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update all dependencies to latest versions.
Update container from single arch atmoz/sftp:alpine-3.7 to multi arch jmcombs/sftp:alpine, see https://github.com/jmcombs/sftp
Replace insecure
"StrictHostKeyChecking", "no"with a sample host key to demonstrate that the test should also cover the host key checking.