Expose gRPC endpoint from BigQueryEmulator #10779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddumelendez
reviewed
Sep 9, 2025
modules/gcloud/src/test/java/org/testcontainers/containers/BigQueryEmulatorContainerTest.java
Outdated
Show resolved
Hide resolved
… that we can connect a BigQueryWriteClient to the table.
Eliassen-Steinar
force-pushed
the
expose-grpc-endpoint
branch
from
6141082 to
ca5fbd7
Compare
eddumelendez
requested changes
Sep 19, 2025
Comment on lines
38
to
47
| private BigQuery getBigQuery(BigQueryEmulatorContainer container) { | ||
| String url = container.getEmulatorHttpEndpoint(); | ||
| return BigQueryOptions | ||
| .newBuilder() | ||
| .setProjectId(container.getProjectId()) | ||
| .setHost(url) | ||
| .setLocation(url) | ||
| .setCredentials(NoCredentials.getInstance()) | ||
| .build().getService(); | ||
| } |
Member
There was a problem hiding this comment.
move this method to the end of the file
modules/gcloud/src/test/java/org/testcontainers/containers/BigQueryEmulatorContainerTest.java
Outdated
Show resolved
Hide resolved
modules/gcloud/src/test/java/org/testcontainers/containers/BigQueryEmulatorContainerTest.java
Outdated
Show resolved
Hide resolved
modules/gcloud/src/test/java/org/testcontainers/containers/BigQueryEmulatorContainerTest.java
Outdated
Show resolved
Hide resolved
modules/gcloud/src/test/java/org/testcontainers/containers/BigQueryEmulatorContainerTest.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| @Test | ||
| void testGrcpEndpoint() throws IOException { |
Member
There was a problem hiding this comment.
can you please add an assertion to this test method?
eddumelendez
force-pushed
the
expose-grpc-endpoint
branch
from
09b8d06 to
ba27f37
Compare
eddumelendez
changed the title
Member
|
Thanks for your contribution, @Eliassen-Steinar ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BigQueryEmulator exposes two endpoints, for http and for gRPC, only the http was exposed by BigQueryEmulatorContainer.
The gRPC port needs to be exposed, as BigQueryWriteSettings needs this port to be configured correctly.
Included test case shows configuration setup and validates that it works as expected.