Update ServiceBusEmulatorContainer (remove deprecation), fix CosmosDB startup #11223
+14
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…verContainer anymore. This is a breaking change, but only in the INCUBATING Azure module. No neat way to do this without any pain. Users of this module will need to: change their imports from: import org.testcontainers.containers.MSSQLServerContainer; to: import org.testcontainers.mssqlserver.MSSQLServerContainer; and: remove the <?> from the MSSQLServerContainer variable.
kiview
previously approved these changes
Nov 14, 2025
Author
|
Hmm, 2 tests fail on unrelated code: CosmosDBEmulatorContainerTest > testWithCosmosClient() FAILED The EventHubsEmulatorContainerTest works fine for me locally. Are these tests flaky? |
Author
Or have the tests not been run for months because of caching, and have now run for the first time because I touched the azure module, and have been broken for a while due to updated images? ;) |
bramvonk
force-pushed
the
update-servicebusemulatorcontainer-to-not-use-deprecated-mssqlservercontainer-anymore
branch
2 times, most recently
from
a55830f to
d319c19
Compare
bramvonk
changed the title
Author
|
I've 'fixed' the problem of the CosmosDB test:
|
Even when that image logs "Started" the API endpoint is not available yet for many seconds. See Azure/azure-cosmos-db-emulator-docker#209 .
bramvonk
force-pushed
the
update-servicebusemulatorcontainer-to-not-use-deprecated-mssqlservercontainer-anymore
branch
from
d319c19 to
6d5b6ef
Compare
eddumelendez
requested changes
Dec 9, 2025
| dockerImageName.assertCompatibleWith(DEFAULT_IMAGE_NAME); | ||
| withExposedPorts(PORT); | ||
| waitingFor(Wait.forLogMessage(".*Started\\r\\n$", 1)); | ||
| // Wait.forLogMessage(".*Started\\r\\n$") is not sufficient with the current version of cosmos db emulator (vnext-EN20251022), |
Member
There was a problem hiding this comment.
can you add a test using that image? AFAIR, it was not working at all with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change, but only in the INCUBATING Azure module. No neat way to do this without any pain.
Users of this module will need to:
change their imports from:
import org.testcontainers.containers.MSSQLServerContainer;
to:
import org.testcontainers.mssqlserver.MSSQLServerContainer;
and:
remove the <?> from the MSSQLServerContainer variable.