Skip to content

Conversation

@marcelstoer
Copy link

@marcelstoer marcelstoer commented Feb 21, 2024

This addresses CVE-2024-25710 and CVE-2024-26308. I know your PR template says to not open PRs to bump dependencies. However, since this is security related it has IMO a higher urgency.

Fixes #8338

@marcelstoer marcelstoer requested a review from a team February 21, 2024 06:05
@marcelstoer
Copy link
Author

@eddumelendez is there any chance this will lead to an immediate release of 1.19.6 once merged?

@eddumelendez
Copy link
Member

Hi, thanks for the PR. There is no plan to update the dependency because of a breaking change in the API. See #8169 (comment)

However, you can do it by yourself on your build file.

@marcelstoer
Copy link
Author

Yes, I understand that. However, at #8169 (comment) you said

If the upgrade is needed because of other reasons...

I thought that commons-compress having critical vulnerabilities be one of those "other" reasons.

@eddumelendez
Copy link
Member

I've tested myself that upgrading independently works perfectly fine. As a library we want to avoid users to do things like described in that thread.

julianladisch added a commit to folio-org/folio-vertx-lib that referenced this pull request Feb 24, 2024
…26.0

Further upgrades for Quesnelia:

Upgrade log4j from 2.22.1 to 2.23.0.

Upgrade testcontainers from 1.19.5 to 1.19.6.

Upgrade commons-compress from 1.24.0 to 1.26.0 fixing
https://nvd.nist.gov/vuln/detail/CVE-2024-25710
https://nvd.nist.gov/vuln/detail/CVE-2024-26308
see testcontainers/testcontainers-java#8354
julianladisch added a commit to folio-org/folio-vertx-lib that referenced this pull request Feb 24, 2024
…26.0

Further upgrades for Quesnelia:

Upgrade log4j from 2.22.1 to 2.23.0.

Upgrade testcontainers from 1.19.5 to 1.19.6.

Upgrade commons-compress from 1.24.0 to 1.26.0 fixing
https://nvd.nist.gov/vuln/detail/CVE-2024-25710
https://nvd.nist.gov/vuln/detail/CVE-2024-26308
see testcontainers/testcontainers-java#8354
@hailuand
Copy link

👋🏾 @eddumelendez How'd you manage this?

I've tested myself that upgrading independently works perfectly fine. As a library we want to avoid users to do things like described in that thread.

When I try to upgrade commons-compress myself, I see a java.lang.NoClassDefFoundError: org/apache/commons/codec/Charsets failure at runtime.

@kkocel
Copy link
Contributor

kkocel commented Mar 7, 2025

@eddumelendez, do you have any mid-term plans for this? Like, making this dependency internal and changing Transferable to not have compress related arguments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Vulnerable dependency commons-compress 1.24.0

4 participants