-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Feature/postponed env read #8824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/postponed env read #8824
Conversation
This reverts commit d321bdc.
|
I added a positive test showing a combination of .dependsOn() and .withEnv() when the dependent container depends on the mapped port of another container. |
|
I added a negative test showing failure in test setup using @container annotation and a combination of .dependsOn() and .withEnv() methods when the dependent container depends on the mapped port of another container. |
|
Hi, thanks for your contributions. The proposal is introducing additional changes that are not expected. |
|
Hi @eddumelendez can you comment about complete proposal here? IMO this part is missing for 'Container' annotation and how I understand the logic expected from 'Container' annotation. |
Related to issue #8823
Replace field declaration in ContainerDef:
Map<String, String> envVars = new HashMap<>();with
Map<String, Supplier<String>> envVars = new HashMap<>();