Skip to content

Conversation

@ZachChuba
Copy link
Contributor

Bumping the version of the shaded snakeyaml jar in core from 1.33 to 2.2, as 1.33 is flagged with CVE-2022-1471.

I have read the PR note on raising them just for dependency upgrades, but there have been two new releases since the 30 days ago this issue was raised and the version has not changed, making me suspect dependabot is missing this.

This addresses issue #9289

@ZachChuba ZachChuba requested a review from a team October 25, 2024 18:55
@eddumelendez
Copy link
Member

Hi, I am pretty sure you also read my comment #9289 (comment)

@eddumelendez
Copy link
Member

Reopening because snakeyaml is a shaded dependency.

@eddumelendez
Copy link
Member

This snakeyaml version is not compatible with current jackson version

@ZachChuba
Copy link
Contributor Author

I would recommend upgrading the jackson version as both this and the current jackson version have critical level security vulnerabilities should be updated... will look into the specific version to bump.

@ZachChuba
Copy link
Contributor Author

Upgrading the whole jackson suite to version 2.15.4 would alleviate these vulnerabilities and be compatible with snakeyaml 2.x. However, it appears this shouldn't be changed for backwards compatibility. These severe vulnerabilities will essentially forbid the use of test containers in enterprises with sonatype lifecycle scanning or other security guards.

    // https://youtu.be/otCpCn0l4Wo
    // The core module depends on jackson-databind 2.8.x for backward compatibility.
    // Any >2.8 version here is not compatible with jackson-databind 2.8.x.

@github-actions github-actions bot added the github_actions Pull requests that update Github_actions code label Jan 28, 2025
@eddumelendez
Copy link
Member

We are planing to update dependencies in the next months. Is there any proof that CVEs are not false-positives for our usage?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update Github_actions code modules/k3s

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants