hivemq > improve "temp-extensions" workaround

[SgtSilvio]

To support the withoutPrepackagedExtensions methods of the HiveMQContainer, we (HiveMQ) initially built in a workaround that copies extensions into /opt/hivemq/temp-extensions/ instead of /opt/hivemq/extensions/ and modifies the container entrypoint and command to move the extensions into their right place.

We have some upcoming changes to the HiveMQ container images that will remove the need for the withoutPrepackagedExtensions methods in most cases. This change applies the workaround only if any of the withoutPrepackagedExtensions methods are called.

This change also makes it easier to use the withCopyToContainer method with a Transferable argument to copy files into an HiveMQ extension's folder by just specifying /opt/hivemq/extensions/ as containerPath without needing to know about any implementation details. Currently, one is limited to methods like withFileInExtensionHomeFolder that apply the "temp-extensions" workaround internally, but these methods only support MountableFile arguments.

[SgtSilvio]

Is there any way we can get merge rights if we just touch the hivemq module?

[SgtSilvio]

@eddumelendez Who should we talk to if we want to become code owners/maintainers of the hivemq module?

[eddumelendez]

Thanks for the contribution, @SgtSilvio. But, we don't think this is a portable solution. Currently, HiveMQ module is provided in Java and NodeJS https://testcontainers.com/modules/hivemq/. Is there a way to hide this behind a env var? That way, no changes would be required in the module. Also, copyFileToContainer must not be overridden.

Who should we talk to if we want to become code owners/maintainers of the hivemq module?

The best person is @kiview

[SgtSilvio]

HiveMQ module is provided in Java and NodeJS

This change tries to remove a workaround that is only present in the Java implementation. I don't see how the NodeJS implementation is affected because it does not have this workaround at all.

copyFileToContainer must not be overridden.

Can you explain me why?

[SgtSilvio]

@kiview As the original contributors of the HiveMQ testcontainers module, we would like to know if it is possible to become maintainers/code owners/allowed reviewers of the hivemq module?
We do not ask for this because we simply want to merge any changes (we are very well concerned about backwards compatibility and don't want to introduce unnecessary changes), but we would like to remove some burden from your side, avoiding the need for you to understand the inner workings of HiveMQ and its container images.
What is your view on this and which options do you see?

[eddumelendez]

Hi @SgtSilvio, testcontainers hosted here are community modules, we do our best effort to maintained thanks to the community. To take full control over it you can host your own module. If so, we can update all our references to the new repository.